After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763078 - build: Update autogen.sh from GNOME recommendation
build: Update autogen.sh from GNOME recommendation
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-04 03:00 UTC by Philip Withnall
Modified: 2016-03-16 18:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Update autogen.sh from GNOME recommendation (2.22 KB, patch)
2016-03-04 03:00 UTC, Philip Withnall 		committed Details | Review
build: Enable gtk-doc during distcheck (1.05 KB, patch)
2016-03-16 16:46 UTC, Debarshi Ray 		committed Details | Review

Description Philip Withnall 2016-03-04 03:00:43 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2016-03-04 03:00:47 UTC 
Created attachment 323055 [details] [review]
build: Update autogen.sh from GNOME recommendation

https://wiki.gnome.org/Projects/GnomeCommon/Migration#autogen.sh

This fixes a srcdir ≠ builddir issue.
Comment 2 Debarshi Ray 2016-03-04 09:46:07 UTC 
Review of attachment 323055 [details] [review]:

Thanks for the patch, Philip.

I trust that you know more about this than me. :) I checked that distcheck still works from a clean git clone.
Comment 3 Philip Withnall 2016-03-04 10:08:11 UTC 
For interest, I found this by setting the buildroot in my .jhbuildrc, as discussed recently on desktop-devel.

Attachment 323055 [details] pushed as 7bf1b3d - build: Update autogen.sh from GNOME recommendation
Comment 4 Debarshi Ray 2016-03-16 16:46:40 UTC 
Created attachment 324120 [details] [review]
build: Enable gtk-doc during distcheck

The previous version of autogen.sh would always pass --enable-gtk-doc. This is no longer the case, which, I guess, is more idiomatic.

However, due to this, one must explicitly pass --enable-gtk-doc when creating tarballs. Otherwise, the documentation will be missing from the tarball. Having --enable-gtk-doc in DISTCHECK_CONFIGURE_FLAGS catches such errors.
Comment 5 Philip Withnall 2016-03-16 18:09:27 UTC 
(In reply to Debarshi Ray from comment #4)
> Created attachment 324120 [details] [review] [review]
> build: Enable gtk-doc during distcheck
> 
> The previous version of autogen.sh would always pass --enable-gtk-doc. This
> is no longer the case, which, I guess, is more idiomatic.
> 
> However, due to this, one must explicitly pass --enable-gtk-doc when
> creating tarballs. Otherwise, the documentation will be missing from the
> tarball. Having --enable-gtk-doc in DISTCHECK_CONFIGURE_FLAGS catches such
> errors.

Looks good to me.