GNOME Bugzilla – Bug 763044
Enable qmlglsink on Rasperry PI
Last modified: 2016-08-15 17:10:46 UTC
Created attachment 322987 [details] [review] Enable qmlgl sink on RPI Currently qmlglsink is not built on RPI. Attached patch adds code that's necessary to get it working there. I had to also modify gstegl.h locally to get it compiled as well but I am not sure if that's the issue on my side: #pragma GCC optimize(gnu89-inline") This is causing build error since this setting is not compatible with C++. Should I add #if !defined(__cplusplus) in gstegl.h to my attachment as well for that?
(In reply to Sergey Borovkov from comment #0) > I had to also modify gstegl.h locally to get it compiled as well but I am > not sure if that's the issue on my side: > #pragma GCC optimize(gnu89-inline") > This is causing build error since this setting is not compatible with C++. > Should I add #if !defined(__cplusplus) in gstegl.h to my attachment as well > for that? Sounds fine by me.
Created attachment 323102 [details] [review] Enable qmlglsink on rpi Update attachment with #ifdef for C++
Comment on attachment 323102 [details] [review] Enable qmlglsink on rpi This doesn't look DispManX/RPi specific, but should work on all platforms with EGL/eglfs, right? Except for the HAVE_QT_RPI Can it be generalized a bit?
Sure. I guess I could merge it with Android code and rename it something like HAVE_QT_EGLFS may be? Would that be fine?
I think so, doesn't look like there's a reason for making this specific to one platform.
Created attachment 323266 [details] [review] Enable qmlglsink on Eglfs Merged code with Android. Still left the check for Android in auto-conf since it needs some other libraries for that case. Tested this on RPI only. Please review if there is anything else that needs to be fixed.
Hi. Can you review this again now?
Review of attachment 323266 [details] [review]: Just one check missing I think. ::: configure.ac @@ +2878,3 @@ + else + AC_DEFINE([HAVE_QT_EGLFS], [], + [Define if Qt eglfs integration is installed]) I think this needs to check pkg-config for Qt5EglDeviceIntegration.pc whenever we attempt to use EGL to make sure that eglfs is actually available.
Sure. I Don't have Qt5EglDeviceIntergration.pc in my Qt for RPI build though so I will have to find out the reason for that first.
Created attachment 326024 [details] [review] Enable qmlglsink on Eglfs
Updated. But I still don't have pkg-config files in my Qt build for Qt5EglDeviceIntegration. So I could not verify that it works 100% - had to comment search for pkg-config file. Without it patch's working for me without any issues.
So can someone else please check if they have it and this is not on my side. This check is not strictly needed, considering that Qt5EglDeviceIntegration is plugin. It's not like if it's missing only qmlglsink won't work - Qt applications won't start at runtime. Might be better not to include it, but that's up to you.
It seems that Qt5EglDeviceIntegration was a fleeting thing. https://bugreports.qt.io/browse/QTBUG-50073
Good to know. Do you want me change anything else?
Created attachment 329864 [details] [review] Enable qmlglsink on Eglfs Recreated patch after rebasing on the latest master
commit 180405714c88c0fe1081f3ec5ca4838c1c127bd0 Author: Sergey Borovkov <sergey.borovkov@wireload.net> Date: Thu Apr 14 18:14:32 2016 +0300 qml: Enable qmlglsink for eglfs https://bugzilla.gnome.org/show_bug.cgi?id=763044
*** Bug 757367 has been marked as a duplicate of this bug. ***