After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763040 - logging: use helpers to uniform the format of messages
logging: use helpers to uniform the format of messages
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2016-03-03 14:16 UTC by Beniamino Galvani
Modified: 2016-03-04 11:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Beniamino Galvani 2016-03-03 14:16:18 UTC 
Now that we have removed the code location from log messages it's
harder to understand where messages come from.

Introduce logging helpers where possible, to uniform the format of messages and prepend a tag specifying the module that generated the message, along with other useful information (interface name, ...).
Comment 1 Beniamino Galvani 2016-03-03 14:19:59 UTC 
Please review branch bg/logging-messages-bgo763040.
Comment 2 Thomas Haller 2016-03-03 17:50:14 UTC 
Looks good to me. Fixups pushed.
Comment 3 Dan Williams 2016-03-03 20:51:48 UTC 
LGTM
Comment 4 Beniamino Galvani 2016-03-04 11:15:31 UTC 
Squashed fixups and merged to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=7d00394f402cdc744c3d30efc7f47810396926be