After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 763030 - W32: renderpng.py gets stuck feeding commands to Inkscape
W32: renderpng.py gets stuck feeding commands to Inkscape
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: adwaita-icon-theme maintainer(s)
adwaita-icon-theme maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-03-03 09:16 UTC by LRN
Modified: 2016-03-03 13:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Feed Inkscape stdin in a separate thread (3.30 KB, patch)
2016-03-03 09:17 UTC, LRN 		committed Details | Review

Description LRN 2016-03-03 09:16:55 UTC 
Noticed this while trying to make a freash build of Adwaita.
Not sure why i never found this before. Maybe i wasn't doing
clean rebuilds. Or Inkscape behaviour changed with new version.
Anyway, the process gets stuck at the beginning.
Comment 1 LRN 2016-03-03 09:17:00 UTC 
Created attachment 322952 [details] [review]
Feed Inkscape stdin in a separate thread

Writing directly into stdin of child processes from the main
thread turned out to cause deadlocks.
Fix this by creating a thread for each child and feeding
its stdin from that thread. Also, instead of writing to
stdin multiple times (for each command), compose a list of
commands in memory and then write them all at once.

Also, use EOFError exception instead of non-existing UnexpectedEndOfStream.
Comment 2 Jakub Steiner 2016-03-03 13:13:47 UTC 
Attachment 322952 [details] pushed as 6b1458d - Feed Inkscape stdin in a separate thread