After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762996 - Revealer doesn't reveal the entire width of a ListBox that has Revealers inside its rows
Revealer doesn't reveal the entire width of a ListBox that has Revealers insi...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-03-02 16:57 UTC by Debarshi Ray
Modified: 2016-04-27 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Reproducer (3.09 KB, text/x-csrc)
2016-03-02 16:57 UTC, Debarshi Ray 		  Details
Add GtkRevealer sizing tests (5.66 KB, patch)
2016-03-03 12:12 UTC, Timm Bäder 		none Details | Review
Don't use TRANSITION_NONE if animations are disabled (2.23 KB, patch)
2016-03-03 12:12 UTC, Timm Bäder 		none Details | Review
Add GtkRevealer sizing tests (5.34 KB, patch)
2016-03-03 17:31 UTC, Timm Bäder 		committed Details | Review
Don't use TRANSITION_NONE if animations are disabled (3.24 KB, patch)
2016-03-03 17:32 UTC, Timm Bäder 		committed Details | Review

Description Debarshi Ray 2016-03-02 16:57:21 UTC 
Created attachment 322886 [details]
Reproducer

See the attached reproducer.

With animations turned off, the entire width of the list box is not shown. That causes the list box to expand when each row is further revealed.

With animations turned on, the entire width of the list box is shown.
Comment 1 Timm Bäder 2016-03-02 18:00:19 UTC 
Soo now that TRANSITION_NONE means 0x0 size when concealed, we do that for all transition types when animations are disabled, because the effective transition type is TRANSITION_NONE.

We could add a private TRANSITION_NONE_VERTICAL or TRANSITION_NONE_HORIZONTAL for the effective transition types, or make them public and support those use cases.
Comment 2 Matthias Clasen 2016-03-02 18:03:49 UTC 
(In reply to Timm Bäder from comment #1)
 
> We could add a private TRANSITION_NONE_VERTICAL or
> TRANSITION_NONE_HORIZONTAL for the effective transition types, or make them
> public and support those use cases.

I would keep them private for now.
Comment 3 Timm Bäder 2016-03-03 12:12:15 UTC 
Created attachment 322968 [details] [review]
Add GtkRevealer sizing tests
Comment 4 Timm Bäder 2016-03-03 12:12:38 UTC 
Created attachment 322969 [details] [review]
Don't use TRANSITION_NONE if animations are disabled
Comment 5 Debarshi Ray 2016-03-03 15:08:28 UTC 
Review of attachment 322969 [details] [review]:

I am not a reviewer, but after some testing I can say that this "works for me".
Comment 6 Timm Bäder 2016-03-03 17:31:45 UTC 
Created attachment 323011 [details] [review]
Add GtkRevealer sizing tests

Remove 2 unneeded functions, they were used in earlier versions of the patch.
Comment 7 Timm Bäder 2016-03-03 17:32:43 UTC 
Created attachment 323012 [details] [review]
Don't use TRANSITION_NONE if animations are disabled

Changing this actually makes the branch added in 0c25c5d43d3a299698a54b31107339861e556a2d obsolete.
Comment 8 Matthias Clasen 2016-03-03 17:41:21 UTC 
Review of attachment 323011 [details] [review]:

yay, a test.
Comment 9 Matthias Clasen 2016-03-03 17:43:51 UTC 
Review of attachment 323012 [details] [review]:

ok
Comment 10 Timm Bäder 2016-03-03 17:57:34 UTC 
Pushed both, thanks.