GNOME Bugzilla – Bug 762990
[PATCH] Added string style to bibtex language spec and some keywords
Last modified: 2017-06-16 09:48:51 UTC
Created attachment 322862 [details] [review] Patch file This patch adds a string style to bibtex language spec.
Created attachment 322863 [details] Screenshot of patch
Review of attachment 322862 [details] [review]: Thanks for your patch. Can you: - create a separate patch to add the keywords. - sort the keywords in alphabetical order. For the string, what if a \{ or \} is present inside the "string"? (I suppose escaping the { or } with a backslash is the way to insert it inside the value). You should create another context to highlight \{ and \} differently, like it is done for e.g. \n in a C string. And reference that context inside the string context.
Created attachment 325314 [details] [review] Patch sorting keywords and added sub context to strings
Created attachment 325315 [details] Screenshot of patch
I added a new patch and a new screenshot according to Sébastien's comment.
Comment on attachment 325314 [details] [review] Patch sorting keywords and added sub context to strings - the patches must be created with the 'git format-patch' command. - create several patches: a first one to sort the current keywords, a second one to add missing keywords, and a third one to add the string style.
Created attachment 353687 [details] [review] Sort keyword
Created attachment 353688 [details] [review] Add missing keywords
Created attachment 353689 [details] [review] Add string context
Review of attachment 353687 [details] [review]: ++
Review of attachment 353688 [details] [review]: ++
Review of attachment 353689 [details] [review]: Looks good, thanks.
Pushed on master: commit 8babd51d45718c7274e5751dd491fb683c36193a commit 72ab978da094f27902b8ef8649fb0bb2a553cd30 commit b36d20bb1deef4e241acaf21f66d638e78fe7ef5 And cherry-picked on gnome-3-24.