GNOME Bugzilla – Bug 762892
joinDialog: Add placeholder content when searching networks returns no result
Last modified: 2017-10-28 17:11:55 UTC
Created attachment 322703 [details] mockup of how placeholder could look like. inside the "Add Network" section of Polari's join dialog we we should give some feedback when searching and no results are found.[1] [1]: https://developer.gnome.org/hig/stable/search.html.en See attached picture.
Adding 'newcomers' tag. This bug should be suitable for new contributors to fix.
Created attachment 341559 [details] [review] placeholder: add placeholder to Add Network section The "Add Network" section of Polari's join dialog doesn't give any feedback when the search does not return any results. To fix this, add a GTK label as a placeholder in the connections list
(In reply to Augusto César from comment #2) > Created attachment 341559 [details] [review] [review] > placeholder: add placeholder to Add Network section > > The "Add Network" section of Polari's join dialog doesn't give any feedback > when the search does not return any results. > > To fix this, add a GTK label as a placeholder in the connections list Cool! And I think we also want an image of the looking glass so it looks like in the mockup I attached. If you want, you can try to look at how this was done in the other places we use a placeholder, fx in userList. :-)
Created attachment 341688 [details] [review] placeholder: add placeholder to Add Network section The "Add Network" section of Polari's join dialog doesn't give any feedback when the search does not return any results. To fix this, add a GTK box with the looking glass icon and a label giving the proper feedback as a placeholder in the connections list.
Review of attachment 341688 [details] [review]: I tested it and it works nicely. The code also looks good to me except that the patch adds some unnecessary whitespace. Remove that and I think your patch is good to go. :-)
Created attachment 341961 [details] [review] placeholder: add placeholder to Add Network section The "Add Network" section of Polari's join dialog doesn't give any feedback when the search does not return any results. To fix this, add a GTK box with the looking glass icon and a label giving the proper feedback as a placeholder in the connections list.
Review of attachment 341961 [details] [review]: hi, your patch still contains whitespace errors. Try "git log -p" and you will see that git will mark the whitespaces with red. If you try to do "git am placeholder-add-placeholder-to-Add-Network-section.patch", git will also give you some warnings. :-)
Created attachment 342060 [details] [review] placeholder: add placeholder to Add Network section The "Add Network" section of Polari's join dialog doesn't give any feedback when the search does not return any results. To fix this, add a GTK box with the looking glass icon and a label giving the proper feedback as a placeholder in the connections list.
Sorry this fell through the cracks - the last revision looks good to me, so pushed to master.