After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762869 - route map remains pressed
route map remains pressed
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-29 12:29 UTC by Andreas Nilsson
Modified: 2016-03-02 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mapView: Convert to GObject signals (1.79 KB, patch)
2016-02-29 19:39 UTC, Jonas Danielsson 		none Details | Review
mainWindow: Toggle sidebar on routeVisible (1.26 KB, patch)
2016-02-29 19:39 UTC, Jonas Danielsson 		none Details | Review
Cast after patch (1.77 MB, video/webm)
2016-02-29 19:43 UTC, Jonas Danielsson 		  Details
mapView: Convert to GObject signals (1.76 KB, patch)
2016-02-29 20:00 UTC, Jonas Danielsson 		committed Details | Review
mainWindow: Toggle sidebar on routeVisible (1.26 KB, patch)
2016-02-29 20:00 UTC, Jonas Danielsson 		none Details | Review
mainWindow: Toggle sidebar on routeVisible (1.31 KB, patch)
2016-03-01 08:18 UTC, Jonas Danielsson 		committed Details | Review

Description Andreas Nilsson 2016-02-29 12:29:00 UTC 
1. Do a route between two points.
2. Search for a third place
3. Sidebar gets closed, but the route icon remains pressed


Screencast of the issue https://cloud.gnome.org/index.php/s/KEOITa5cB54ytmm
Comment 1 Jonas Danielsson 2016-02-29 19:39:48 UTC 
Created attachment 322696 [details] [review]
mapView: Convert to GObject signals
Comment 2 Jonas Danielsson 2016-02-29 19:39:53 UTC 
Created attachment 322697 [details] [review]
mainWindow: Toggle sidebar on routeVisible
Comment 3 Jonas Danielsson 2016-02-29 19:43:50 UTC 
Created attachment 322698 [details]
Cast after patch
Comment 4 Jonas Danielsson 2016-02-29 20:00:08 UTC 
Created attachment 322700 [details] [review]
mapView: Convert to GObject signals
Comment 5 Jonas Danielsson 2016-02-29 20:00:14 UTC 
Created attachment 322701 [details] [review]
mainWindow: Toggle sidebar on routeVisible
Comment 6 Marcus Lundblad 2016-02-29 22:33:42 UTC 
Hmm, I tried applying the patches. It seems now clicking the route button does nothing… Using the context menu to initiate routing seems to work though.
Comment 7 Jonas Danielsson 2016-03-01 08:18:04 UTC 
Created attachment 322725 [details] [review]
mainWindow: Toggle sidebar on routeVisible
Comment 8 Marcus Lundblad 2016-03-01 20:07:33 UTC 
Review of attachment 322700 [details] [review]:

LGTM
Comment 9 Marcus Lundblad 2016-03-01 20:08:12 UTC 
Review of attachment 322725 [details] [review]:

LGTM
Comment 10 Marcus Lundblad 2016-03-01 20:08:39 UTC 
(In reply to Marcus Lundblad from comment #6)
> Hmm, I tried applying the patches. It seems now clicking the route button
> does nothing… Using the context menu to initiate routing seems to work
> though.

Works great with the latest patch!
Comment 11 Jonas Danielsson 2016-03-02 08:46:07 UTC 
Review of attachment 322700 [details] [review]:

Pushed!
Comment 12 Jonas Danielsson 2016-03-02 08:46:15 UTC 
Review of attachment 322725 [details] [review]:

Thanks!