After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762860 - sdp: Add new sdpsrc element and some sdpdemux bugfixes
sdp: Add new sdpsrc element and some sdpdemux bugfixes
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-29 09:56 UTC by Sebastian Dröge (slomo)
Modified: 2016-03-25 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sdpdemux: Only create RTCP part of the pipeline if RTCP is signalled in the SDP (1.55 KB, patch)
2016-02-29 09:56 UTC, Sebastian Dröge (slomo)
rejected Details | Review
sdp: Add new sdpsrc element (13.59 KB, patch)
2016-02-29 09:56 UTC, Sebastian Dröge (slomo)
none Details | Review
sdpdemux: Add pads with the correct names in case an rtpbin is used (1.54 KB, patch)
2016-02-29 09:56 UTC, Sebastian Dröge (slomo)
committed Details | Review
sdpdemux: Set caps to application/x-rtp instead of application/x-unknown as returned by the SDP helpers (1.33 KB, patch)
2016-02-29 09:56 UTC, Sebastian Dröge (slomo)
committed Details | Review
sdp: Add new sdpsrc element (13.67 KB, patch)
2016-02-29 10:02 UTC, Sebastian Dröge (slomo)
none Details | Review
sdp: Add new sdpsrc element (13.72 KB, patch)
2016-03-02 08:00 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2016-02-29 09:56:31 UTC
See commit messages.
Comment 1 Sebastian Dröge (slomo) 2016-02-29 09:56:34 UTC
Created attachment 322634 [details] [review]
sdpdemux: Only create RTCP part of the pipeline if RTCP is signalled in the SDP
Comment 2 Sebastian Dröge (slomo) 2016-02-29 09:56:40 UTC
Created attachment 322635 [details] [review]
sdp: Add new sdpsrc element

This can read from an SDP file or get the SDP data via property. Works
around the problem that sdpdemux inside decodebin fails because the
GST_STATE_CHANGE_NO_PREROLL is not observed by the pipeline.

See https://bugzilla.gnome.org/show_bug.cgi?id=702495
Comment 3 Sebastian Dröge (slomo) 2016-02-29 09:56:45 UTC
Created attachment 322636 [details] [review]
sdpdemux: Add pads with the correct names in case an rtpbin is used

They're supposed to be stream_%u and not recv_rtp_src_%u_%u_%u.
Comment 4 Sebastian Dröge (slomo) 2016-02-29 09:56:50 UTC
Created attachment 322637 [details] [review]
sdpdemux: Set caps to application/x-rtp instead of application/x-unknown as returned by the SDP helpers

The SDP helpers can't know if this is going to be RTP, SRTP, or ....
Comment 5 Sebastian Dröge (slomo) 2016-02-29 10:02:09 UTC
Created attachment 322639 [details] [review]
sdp: Add new sdpsrc element

This can read from an SDP file or get the SDP data via property. Works
around the problem that sdpdemux inside decodebin fails because the
GST_STATE_CHANGE_NO_PREROLL is not observed by the pipeline.

See https://bugzilla.gnome.org/show_bug.cgi?id=702495
Comment 6 Sebastian Dröge (slomo) 2016-02-29 10:05:19 UTC
Comment on attachment 322634 [details] [review]
sdpdemux: Only create RTCP part of the pipeline if RTCP is signalled in the SDP

This is actually wrong. If no rtcp attribute is in the SDP, it's supposed to be the next higher port.
Comment 7 Sebastian Dröge (slomo) 2016-02-29 10:07:30 UTC
Comment on attachment 322637 [details] [review]
sdpdemux: Set caps to application/x-rtp instead of application/x-unknown as returned by the SDP helpers

This one is a regression from 1.6
Comment 8 Sebastian Dröge (slomo) 2016-02-29 10:07:54 UTC
Comment on attachment 322636 [details] [review]
sdpdemux: Add pads with the correct names in case an rtpbin is used

This one a regression from the 0.10 port it seems
Comment 9 Sebastian Dröge (slomo) 2016-03-02 08:00:12 UTC
Created attachment 322828 [details] [review]
sdp: Add new sdpsrc element

This can read from an SDP file or get the SDP data via property. Works
around the problem that sdpdemux inside decodebin fails because the
GST_STATE_CHANGE_NO_PREROLL is not observed by the pipeline.

See https://bugzilla.gnome.org/show_bug.cgi?id=702495
Comment 10 Sebastian Dröge (slomo) 2016-03-25 10:52:36 UTC
Attachment 322828 [details] pushed as b53f682 - sdp: Add new sdpsrc element