After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762851 - "Second" without any more info is difficult to translate
"Second" without any more info is difficult to translate
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Internationalization (i18n)
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-29 07:02 UTC by Alexandre Franke
Modified: 2016-03-03 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
properties-window: add comments for translators (2.55 KB, patch)
2016-03-03 09:29 UTC, Carlos Soriano
committed Details | Review
preferences-window: add context to ordinals (2.78 KB, patch)
2016-03-03 13:08 UTC, Carlos Soriano
none Details | Review
preferences-window: add context to ordinals (2.79 KB, patch)
2016-03-03 15:49 UTC, Carlos Soriano
committed Details | Review

Description Alexandre Franke 2016-02-29 07:02:44 UTC
https://git.gnome.org/browse/nautilus/tree/src/resources/ui/nautilus-preferences-window.ui has "Second" as a translatable string. By reading the surrounding lines, one can see that "First" and "Third" are also there so you know it's not seconds that make a minute. That's still not enough. Can you please add a comment to explain the first, second and third what?

https://wiki.gnome.org/TranslationProject/DevGuidelines/Use%20comments
Comment 1 Carlos Soriano 2016-03-03 09:29:53 UTC
Created attachment 322956 [details] [review]
properties-window: add comments for translators

First, Second, Third were lacking context.
Comment 2 Carlos Soriano 2016-03-03 09:32:50 UTC
Thanks for reporting, reopen if the comments are not good enough.

Attachment 322956 [details] pushed as 959ef42 - properties-window: add comments for translators
Comment 3 Alexandre Franke 2016-03-03 11:06:36 UTC
We actually need to know the second what it is about. In some languages, the grammatical gender will change the word you choose. That's also why I said context.

I gave a link to the translation comments documentation, but you probably want to use a translation context in this case. Sorry for misleading you.

https://wiki.gnome.org/TranslationProject/DevGuidelines/Translation%20contexts
Comment 4 Carlos Soriano 2016-03-03 13:08:16 UTC
Created attachment 322973 [details] [review]
preferences-window: add context to ordinals
Comment 5 Carlos Soriano 2016-03-03 13:09:47 UTC
can you check whether the wording is clear enough?
Comment 6 Alexandre Franke 2016-03-03 13:20:16 UTC
Review of attachment 322973 [details] [review]:

::: src/resources/ui/nautilus-preferences-window.ui
@@ +423,3 @@
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
+                        <property name="label" translatable="yes" comments="Translators: This is an ordinal number" context="the n positon of an icon caption">Second</property>

There's a typo (positon) and you should use n-th rather than n.
Comment 7 Carlos Soriano 2016-03-03 15:49:51 UTC
Created attachment 322992 [details] [review]
preferences-window: add context to ordinals
Comment 8 Carlos Soriano 2016-03-03 15:53:27 UTC
Thanks for the review! Pushed with comments fixed.

Attachment 322992 [details] pushed as e297bfc - preferences-window: add context to ordinals