After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762850 - jpeg encoder: initialize VAEncSliceParameterBufferJPEG before using it
jpeg encoder: initialize VAEncSliceParameterBufferJPEG before using it
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-29 06:47 UTC by Lim Siew Hoon
Modified: 2016-02-29 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add memset to initialize VAEncSliceParameterBufferJPEG before using it. (972 bytes, patch)
2016-02-29 06:47 UTC, Lim Siew Hoon 		none Details | Review

Description Lim Siew Hoon 2016-02-29 06:47:31 UTC 
Created attachment 322624 [details] [review]
Add memset to initialize VAEncSliceParameterBufferJPEG before using it.

We are using to Klockwork(KW) tool to scan code based for gstreamer-vaapi. It is hitting the critical severity in the KW report. 

It should be doing initialize first before start use it. Else it could be possibility chance using the garbage value.
Comment 1 sreerenj 2016-02-29 10:03:44 UTC 
Pushed, thanks for the patch
commit 0bae36bb88324c9cbc94477ef8a0c2be797db18d
Author: Lim Siew Hoon <siew.hoon.lim@intel.com>
Date:   Mon Feb 29 11:55:27 2016 +0200

    Add memset to initialize value for VAEncSliceParameterBufferJPEG
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762850


Please add bugzilla link to the commit message next time onward :)