After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762834 - Don't break string just because of markup
Don't break string just because of markup
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-28 21:10 UTC by Alexandre Franke
Modified: 2016-03-01 21:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
view: Don't split string when it is misleading (1.99 KB, patch)
2016-02-29 17:06 UTC, Alessandro Bono 		accepted-commit_now Details | Review

Description Alexandre Franke 2016-02-28 21:10:35 UTC 
I understand why you wrote "Documents from your %s and %s will appear here." this way, but it's causing confusion and is not a case where you should do it this way.

Read https://wiki.gnome.org/TranslationProject/DevGuidelines/Avoid%20markup%20wherever%20possible

Your in the first case, "positional markup", therefore you should leave the string in one and not split it the way you do. Splitting is misleading and I had a translator creating a translation that would be something like "Documents from your Online Accounts accounts and Document Folder folder will appear here."
Comment 1 Alexandre Franke 2016-02-29 15:55:51 UTC 
_("Documents from your <a href=\"system-settings\">Online Accounts</a> and <a href=\"file://%s\">Documents folder</a> will appear here.").format(GLib.get_user_special_dir(GLib.UserDirectory.DIRECTORY_DOCUMENTS));

should work
Comment 2 Alessandro Bono 2016-02-29 17:06:48 UTC 
Created attachment 322676 [details] [review]
view: Don't split string when it is misleading
Comment 3 Debarshi Ray 2016-02-29 19:11:56 UTC 
Review of attachment 322676 [details] [review]:

Thanks. Looks good to me.