After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762807 - Show sane default value for build workers preference
Show sane default value for build workers preference
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: preferences
3.19.x
Other Linux
: Normal minor
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-28 01:09 UTC by Michael Catanzaro
Modified: 2016-05-05 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
prefs: show better values than 0 and -1 for parallel build workers (3.12 KB, patch)
2016-05-05 14:40 UTC, Christian Hergert 		committed Details | Review

Description Michael Catanzaro 2016-02-28 01:09:31 UTC 
The default value for the "number of parallel build workers preference" is -1. That's fine for the gsettings schema but it shouldn't be displayed to users in the preferences dialog, it should be converted into the actual value that would be used.
Comment 1 Christian Hergert 2016-05-05 14:40:05 UTC 
Created attachment 327351 [details] [review]
prefs: show better values than 0 and -1 for parallel build workers
Comment 2 Christian Hergert 2016-05-05 14:42:13 UTC 
Fixed, however we don't show the actual value that would be used because
that would be really weird to hit + from 4 and get 1.

Instead, we use textual descriptions.

Not happy about using the word "Default" in here, but the default value
is sort of nebulous, and up to the build system to define. For example,
in autotools, we default to N_CPU + 1.

For 0, we show "Number of CPU". Which I'd love better wording for...

Attachment 327351 [details] pushed as a5eb1b6 - prefs: show better values than 0 and -1 for parallel build workers