GNOME Bugzilla – Bug 762789
themes in ~/.local/share/themes are listed twice
Last modified: 2017-12-17 18:24:28 UTC
Description of problem: When installing a theme in ~/.local/share/themes these themes are listed twice in gnome-tweak-tool because ~/.themes is automaticly created as a symlink to ~/.local/share/themes Version-Release number of selected component (if applicable): $ rpm -q gnome-tweak-tool gnome-tweak-tool-3.18.1-1.fc23.noarch How reproducible: allways Steps to Reproduce: 1. Make sure ~/.themes does not exist 2. Install a theme in ~/.local/share/themes 3. Open gnome-tweak-tool and open the appearance view Actual results: Themes installed in ~/.local/share/themes are listed twice Expected results: All themes should be listed once Additional info:
Who creates a symlink from ~/.themes ?
I don't know. It seems to be created automaticly from the moment a theme is copied (or symlinked) into ~/.local/share/themes But even if you create that symlink manually that has no effect on that issue. The theme is still listed twice.
...issue still exist also on gnome-tweak-tool 3.26.3 : btw for me there's no automatic creation of the ~/.themes symlink (archlinux and gnome 3.26.2) but I need to created it manually otherwise all gtk2 apps don't found the gtk2 themes located in ~/.local/share/themes and that apps use the ugly default gtk2 theme then if you have the ~/.themes symlink to ~/.local/share/themes , themes are listed twice obviously the issue happens if you have some gtk3/2 theme installed in your home : if you have only themes installed globally under /usr/share/themes the issue doesn't occur. Andrea
I'm pushing this fix to master and to the gnome-3-26 branch. This is too late for 3.26.3 but I may do a 3.26.4 later. You can ask your distro to cherry-pick these fixes if you want them sooner.
...first of all many thanks to solve this little but annoying issue then if a 3.26.4 release is planned , I'll wait for it, no problem! ;-) Andrea
just for curiosity , I tried to compile by myself gtt from git 3.26 branch with your latest commit and I noticed that the issue still exist for gnome shell theme: they are listed twice I was convinced that original issue was related only to gtk2/3 themes then I downgrade gtt to official 3.26.3 arch package n but also on that release gnome shell themes are listed twice.. so I wrong remember.. Thanks in advance if you will take a look also for this. Andrea
Thank you for following up. I have applied the fix to GNOME Shell themes now too.
Should not the same fix be also applied to cursor themes?
(In reply to Jan Tojnar from comment #8) > Should not the same fix be also applied to cursor themes? Jan, do you want to submit a patch for that?
Created attachment 365637 [details] [review] Dedupe cursors
Jan, generally it's a better idea to open a new bug rather than commenting on an old closed bug. Could you give me a test case for the cursor problem? I don't really use cursor themes from my home directory.
(In reply to Jeremy Bicha from comment #11) > Could you give me a test case for the cursor problem? I don't really use > cursor themes from my home directory. You can try something like this (depending on where adwaita-icon-theme is installed). mkdir -p ~/.local/share/icons ln -s /usr/share/icons/Adwaita ~/.local/share/icons/ ln -s ~/.local/share/icons ~/.icons
Ok, I see now. I think my problem was that I needed to update my icon cache after copying the Adwaita icon theme to my home directory. Could you submit your patch in git format? (so that it includes your name as Author and includes an appropriate commit message)
Created attachment 365648 [details] [review] Don't duplicate the cursor theme name
Comment on attachment 365648 [details] [review] Don't duplicate the cursor theme name Thank you. I have pushed this to master and the gnome-3-26 branch.