GNOME Bugzilla – Bug 762765
goom: crashes on window resize
Last modified: 2016-02-27 18:36:36 UTC
$ gst-launch-1.0 audiotestsrc ! goom ! ximagesink Resize window (make larger) => displays garbage then crashes: Program received signal SIGSEGV, Segmentation fault.
+ Trace 236009
Thread 140737277159168 (LWP 5065)
==4956== Thread 3 audiotestsrc0:sr: ==4956== Invalid read of size 1 ==4956== at 0x9AC9F38: shader_fade (gstaudiovisualizer.c:185) ==4956== by 0x9ACCE67: gst_audio_visualizer_chain (gstaudiovisualizer.c:1183) ==4956== by 0x4EA3CA1: gst_pad_chain_data_unchecked (gstpad.c:4155) ==4956== by 0x4EA3CA1: gst_pad_push_data (gstpad.c:4407) ==4956== by 0x4EABE52: gst_pad_push (gstpad.c:4526) ==4956== by 0x8F84A74: gst_base_src_loop (gstbasesrc.c:2850) ==4956== by 0x4ED5C50: gst_task_func (gsttask.c:332) ==4956== by 0x562835D: g_thread_pool_thread_proxy (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2) ==4956== by 0x56279C4: g_thread_proxy (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4600.2) ==4956== by 0x5CD9283: start_thread (pthread_create.c:333) ==4956== Address 0x88187a0 is 0 bytes after a block of size 307,328 alloc'd ==4956== at 0x4C2BBD5: calloc (vg_replace_malloc.c:711) ==4956== by 0x989BE76: init_buffers (goom_core.c:62) ==4956== by 0x989BF20: goom_init (goom_core.c:89) ==4956== by 0x9894420: gst_goom_init (gstgoom.c:138) ==4956== by 0x5193328: g_type_create_instance (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2) ==4956== by 0x51752BA: g_object_new_internal (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2) ==4956== by 0x5176BA0: g_object_newv (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.4600.2) ==4956== by 0x4E8FF54: gst_element_factory_create (gstelementfactory.c:376) ==4956== by 0x4E9003D: gst_element_factory_make (gstelementfactory.c:446) ==4956== by 0x4EF9886: priv_gst_parse_yyparse (grammar.y:713) ==4956== by 0x4EFA908: priv_gst_parse_launch (grammar.y:1075) ==4956== by 0x4EF1AAE: gst_parse_launch_full (gstparse.c:325)
Regression from the audiovisualizer port.
It crashes in 1.6 as well (with the internal/private audiovisualizer) :)
Well, it's a regression from 1.4 :)
commit 03d2ae154e3a36053494912185c0d1964633f30b Author: Sebastian Dröge <sebastian@centricular.com> Date: Sat Feb 27 20:33:32 2016 +0200 goom: Use goom_set_resolution() instead of recreating the goom instance when the resolution changes https://bugzilla.gnome.org/show_bug.cgi?id=762765 commit bd0d2a3d7de8149dd4840a882fdcfa09d663d5d4 Author: Sebastian Dröge <sebastian@centricular.com> Date: Sat Feb 27 20:32:45 2016 +0200 Revert "goom: Initialize the goom struct only once we know width/height and recreate it if those change" This reverts commit cc6e102643c1bae928316dca9f34db028fb9a67e. commit cc6e102643c1bae928316dca9f34db028fb9a67e Author: Sebastian Dröge <sebastian@centricular.com> Date: Sat Feb 27 20:31:15 2016 +0200 goom: Initialize the goom struct only once we know width/height and recreate it if those change Fixes crash when the width and/or height is changing. https://bugzilla.gnome.org/show_bug.cgi?id=762765