GNOME Bugzilla – Bug 762714
Use https:// by default instead of git://
Last modified: 2017-08-01 07:16:21 UTC
So I was discussing with Mathieu Bridon about this change. Currently using git has few issues, which most important are: - Users behind proxies usually block git:// and cannot use jhbuild so easily. This is common in countries like India. This is giving newcomers a hard start. - When we provide permissions to push, the user needs to change the protocol used. The user could set the user setting even without permission, and find out automatically that it works when we give him permissions. - git protocol cannot avoid some man in the middle attacks, which https would solve. I'm not expert on this though, but I think this change will be good.
I agree with changing the default to use HTTPS, for as many sources as possible. (In reply to Carlos Soriano from comment #0) > - When we provide permissions to push, the user needs to change the protocol > used. The user could set the user setting even without permission, and find > out automatically that it works when we give him permissions. This is going to be a problem regardless, since you need to use SSH if you want to push, and we can't default to SSH. I think by the time users get a GNOME account with push access, they are experienced enough to be able to change the protocol, though.
> This is going to be a problem regardless, since you need to use SSH if you want to push, and we can't default to SSH. We could enable pushing over https though, at which point there would be no need to change anything in the jhbuild config file. I think this is what Carlos meant in his original comment. Of course, I don't think we allow pushing over https at the moment, so that would be a separate issue.
We should use https:// for all tarball URLs too as well as git repos. Anything not available via HTTPS should not be considered an acceptable dependency of GNOME.
Fixed. Note some modules (e.g. gnome-online-accounts, probably more) hardcode git:// use in .gitmodules. That needs to be fixed as well to be able to build in these situations.
Created attachment 356678 [details] [review] Fix the git.gnome.org HTTPS URLs
It seems you broke jhbuild using the wrong git.gnome.org URLs. Previous comment has a patch fixing that. :)
I spent all day testing that change over slow hotel wi-fi, but didn't matter as my jhbuildrc won in the end. :(
Attachment 356678 [details] pushed as 675e649 - Fix the git.gnome.org HTTPS URLs
(In reply to Michael Catanzaro from comment #7) > I spent all day testing that change over slow hotel wi-fi, but didn't matter > as my jhbuildrc won in the end. :( Yeah, I only found the problem because I share my room with someone who didn't have any jhbuildrc and tried a build for the first time. ;P