GNOME Bugzilla – Bug 762710
gst_discoverer_info_copy loses some data members of the source GstDiscovererInfo object.
Last modified: 2016-04-14 17:43:30 UTC
Created attachment 322434 [details] [review] Simply copy the missing data members. The function gst_discoverer_info_copy doesn't copy the data members seekable and result of the source GstDiscovererInfo. In the case of copying a GstDiscovererInfo for later use, the seekbale will be undefined, which in practice usually will be false, even though the seekable of the original GstDiscovererInfo is true.
Comment on attachment 322434 [details] [review] Simply copy the missing data members. Thanks for the patch, looks correct :) Can you provide this as a "git format-patch" style patch?
Make sure to also properly set your mail address and name in GIT before doing that :) Thanks!
vgdoqd, could you provide us with a name and e-mail address for patch attribution please?
Pushed this now since it's trivial anyway: commit 2102fdc983e13bc945c552a88c1c007f358363da Author: Tim-Philipp Müller <tim@centricular.com> Date: Sat Apr 2 10:09:07 2016 +0100 discoverer: copy over result and seekable fields when copying a discoverer info The function gst_discoverer_info_copy doesn't copy the data members seekable and result of the source GstDiscovererInfo. In the case of copying a GstDiscovererInfo for later use, the seekbale will be undefined, which in practice usually will be false, even though the seekable of the original GstDiscovererInfo is true. https://bugzilla.gnome.org/show_bug.cgi?id=762710