After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762684 - hlsdemux: tests: pass test name into test setup function
hlsdemux: tests: pass test name into test setup function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.7.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-25 15:30 UTC by A Ashley
Modified: 2016-02-25 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
hlsdemux: tests: pass test name into test setup function (2.98 KB, patch)
2016-02-25 15:32 UTC, A Ashley
committed Details | Review

Description A Ashley 2016-02-25 15:30:31 UTC
All hlsdemux tests create a GstStructure called "state" that can be used by test cases to store information during a test. The name of this structure is arbitrary. When the code was written, the intention was to use the name of the test, to aid debugging. However, during test development this was lost, so that the state GstStructure is always given the name "setup_test_variables".
Comment 1 A Ashley 2016-02-25 15:32:53 UTC
Created attachment 322386 [details] [review]
hlsdemux: tests: pass test name into test setup function
Comment 2 Tim-Philipp Müller 2016-02-25 17:45:00 UTC
commit 35e00becfe63f2d726e66f92145cbf6a2f3cae87
Author: Alex Ashley <alex.ashley@youview.com>
Date:   Mon Jan 18 08:50:34 2016 +0000

    hlsdemux: tests: pass test name into test setup function
    
    All hlsdemux tests create a GstStructure called "state" that can be used
    by test cases to store information during a test. The name of this
    structure is arbitrary. When the code was written, the intention was
    to use the name of the test, to aid debugging. However, during
    development this was lost, so that the state GstStructure is always
    given the name "setup_test_variables".
    
    This commit changes this so that the name of the test is used.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762684