After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762637 - build: Unconditionally dist tapset files
build: Unconditionally dist tapset files
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-02-24 18:45 UTC by Colin Walters
Modified: 2016-02-24 18:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Unconditionally dist tapset files (1.23 KB, patch)
2016-02-24 18:45 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2016-02-24 18:45:46 UTC 
Apparently whoever made the last tarball didn't have `--enable-systemtap`.
Disted files shouldn't depend on build flags.

Also, it is cathartic for me to say tarballs are dumb and we should
just be pulling from git which is what's canonically tracking what's
source code and what's not and we don't need to repeat ourself in
`Makefile.am`.
Comment 1 Colin Walters 2016-02-24 18:45:54 UTC 
Created attachment 322272 [details] [review]
build: Unconditionally dist tapset files
Comment 2 Colin Walters 2016-02-24 18:46:28 UTC 
This is (at least one) reason why http://koji.fedoraproject.org/koji/buildinfo?buildID=736499 failed.
Comment 3 Matthias Clasen 2016-02-24 18:49:00 UTC 
Review of attachment 322272 [details] [review]:

Looks right
Comment 4 Colin Walters 2016-02-24 18:54:24 UTC 
Attachment 322272 [details] pushed as ad2092b - build: Unconditionally dist tapset files