After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762617 - ostree_repo_static_delta_execute_offline regression
ostree_repo_static_delta_execute_offline regression
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-24 14:21 UTC by Alexander Larsson
Modified: 2016-02-24 14:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
deltas: Fix regression in ostree_repo_static_delta_execute_offline (1.72 KB, patch)
2016-02-24 14:22 UTC, Alexander Larsson 		accepted-commit_now Details | Review

Description Alexander Larsson 2016-02-24 14:21:48 UTC 
This changed to not support passing in filenames (not directory names) in a recent commit, which broke xdg-app bundle installation.
Comment 1 Alexander Larsson 2016-02-24 14:22:23 UTC 
Created attachment 322246 [details] [review]
deltas: Fix regression in ostree_repo_static_delta_execute_offline

xdg-app passed this a filename directly, and in this case it should be
used as is. This regressed to always look for "superblock" in the same
directory as the passed in filename.
Comment 2 Colin Walters 2016-02-24 14:36:50 UTC 
Review of attachment 322246 [details] [review]:

Damn, sorry...I need to work xdg-app into my day-to-day workflow instead of just testing it occasionally.  Or stand up xdg-app testing in Continuous.

Anyways, this looks reasonable, and feel free to commit as is, but it'd also be good to have a test case covering this.
Comment 3 Alexander Larsson 2016-02-24 14:56:03 UTC 
Attachment 322246 [details] pushed as 1833142 - deltas: Fix regression in ostree_repo_static_delta_execute_offline