GNOME Bugzilla – Bug 762595
search no longer allows to keynav to the results
Last modified: 2016-03-03 10:26:16 UTC
I used to be able to arrow key into the result area to dig deeper into a result folder. I believe it was cursor down. I think we should even preselect the first result so you can just hit enter, ala gnome-shell.
Problem with preselecting is that files are being reordered while they are found, so you can end with the selection of the user changing all around.
to make it clearer, we select the first item once the search is done, but not while performing the search.
Created attachment 322958 [details] [review] list-view: unselect all items before selecting a new one It shouldn't happen, but better to be correct here.
Created attachment 322959 [details] [review] files-view: select first on loading only if no previous selection Avoid to select the first file if there is a selection already. Although we were checking for the pending selection, it could be that there is a selection already because the user selected a file. This will be needed also for an upcoming patch, where we always select the first file on displaying new files, even if the directory is not fully loaded.
Created attachment 322960 [details] [review] files-view: select first file even when directory not fully loaded Currently we were waiting until the view was fully loaded to select the first file. This is fine when only navigating. However, for search, we actually want to select the first file in order to allow the user to open right away the most relevant file. Let's see if this brings problems on icons jumping in large directories, but I hope it doesn't in the most common cases.
Attachment 322958 [details] pushed as b33785a - list-view: unselect all items before selecting a new one Attachment 322959 [details] pushed as bf91cdb - files-view: select first on loading only if no previous selection Attachment 322960 [details] pushed as 2fa597e - files-view: select first file even when directory not fully loaded