After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762589 - Can't add dictionary sources
Can't add dictionary sources
Status: RESOLVED FIXED
Product: gnome-dictionary
Classification: Core
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: gnome-dictionary-maint
gnome-dictionary-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-24 09:36 UTC by megaminxwin
Modified: 2017-10-06 09:16 UTC
See Also:
GNOME target: ---
GNOME version: 3.17/3.18



Description megaminxwin 2016-02-24 09:36:26 UTC
I'm running Arch in a VM, using GNOME 3.18. I'm trying to get the dictionary to use a local source, but the button to add dictionaries is greyed out. I can get to the menu which says "add dictionary source", and enter the hostname and everything, but it won't actually let me add it.

Also, if I try to edit an existing dictionary source, nothing sticks. After I close the dialog box, when I reopen it the exact same settings are back.

I ran from the command line and I got these messages:

(gnome-dictionary:16760): Gdict-CRITICAL **: gdict_database_chooser_get_context: assertion 'GDICT_IS_DATABASE_CHOOSER (chooser)' failed

(gnome-dictionary:16760): Gdict-WARNING **: Attempting to retrieve the available databases, but no GdictContext has been set.  Use gdict_database_chooser_set_context() before invoking gdict_database_chooser_refresh().
Comment 1 Juan R. Garcia Blanco 2016-03-06 19:31:41 UTC
Thank you for reporting this problem.

Please find below some comments:

- Existing dictionary sources: actually pre-installed dictionary sources are not meant to be edited, and therefore edition is prevented on them.
- Adding sources: it seems that nothing changed with respect to previous versions in which this feature was known to work. Using gdb I cannot stop at on_transport_changed, for some reason. I'll continue investigating, as it is clearly a regression.
Comment 2 Sarah Hall 2017-08-21 19:09:42 UTC
I have this bug too.
I am using gnome-dictionary 3.24.0

I can't add extra dictionaries the "Add" button remains grayed out.

When I run gnome-dictionary via the command line and open the Preferences window.
If I then click on the "+" to add a dictionary source the command line throws up this:



$ gnome-dictionary

(gnome-dictionary:5089): Gtk-CRITICAL **: Unable to retrieve object 'description_entry' from class template for type 'GdictSourceDialog' while building a 'GdictSourceDialog'

(gnome-dictionary:5089): Gtk-CRITICAL **: gtk_combo_box_set_active: assertion 'GTK_IS_COMBO_BOX (combo_box)' failed

(gnome-dictionary:5089): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(gnome-dictionary:5089): GLib-GObject-CRITICAL **: g_signal_emit_by_name: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed







Ubuntu GNOME 17.04 amd64
Kernel: 4.10.0-32-generic x86_64 (64 bit gcc: 6.3.0)
Comment 3 Bruno Boaventura 2017-09-20 02:57:53 UTC
(In reply to Sarah Hall from comment #2)
> $ gnome-dictionary
> 
> (gnome-dictionary:5089): Gtk-CRITICAL **: Unable to retrieve object
> 'description_entry' from class template for type 'GdictSourceDialog' while
> building a 'GdictSourceDialog'
> 
> (gnome-dictionary:5089): Gtk-CRITICAL **: gtk_combo_box_set_active:
> assertion 'GTK_IS_COMBO_BOX (combo_box)' failed
> 
> (gnome-dictionary:5089): GLib-GObject-WARNING **: invalid (NULL) pointer
> instance
> 
> (gnome-dictionary:5089): GLib-GObject-CRITICAL **: g_signal_emit_by_name:
> assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed



It happens with 3.26 in Debian Testing too.
Comment 4 Sarah Hall 2017-09-27 11:09:27 UTC
Could a gnome-dictionary developer please at least acknowledged this bug?
Its a significant bug. I'd say the 'Importance' level should be raised to 'major'.
I'd raise it myself only it won't let me/ I can't see how to do it.
Comment 5 Bruno Boaventura 2017-09-27 23:17:13 UTC
(In reply to Sarah Hall from comment #4)
> Could a gnome-dictionary developer please at least acknowledged this bug?
> Its a significant bug. I'd say the 'Importance' level should be raised to
> 'major'.
> I'd raise it myself only it won't let me/ I can't see how to do it.

Change made.
Comment 6 Sarah Hall 2017-09-30 13:36:17 UTC
> Change made.

Thanks :)
Comment 7 Emmanuele Bassi (:ebassi) 2017-09-30 15:33:35 UTC
The importance field is not used to prioritise or "acknowledge" bugs; it's just a tool for queries.
Comment 8 Emmanuele Bassi (:ebassi) 2017-09-30 16:00:25 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.

Relevant commits:
  https://git.gnome.org/browse/gnome-dictionary/commit/?id=92e9d982ed4014a93f8affa6d69900807ce5ccba
  https://git.gnome.org/browse/gnome-dictionary/commit/?id=679b3b83f35bc8e602f2d3c8b03736e9156fea33

I've cherry picked them to the 3.24 branch as well.

I'm going to do a 3.26.1 release by Monday, October 2nd; I'll also do an additional 3.24.1 release at that time, so that older distributions can pick it up.
Comment 9 Bruno Boaventura 2017-10-01 21:14:34 UTC
(In reply to Emmanuele Bassi (:ebassi) from comment #7)
> The importance field is not used to prioritise or "acknowledge" bugs; it's
> just a tool for queries.

Sorry about that.
Comment 10 Sarah Hall 2017-10-06 09:16:34 UTC
(In reply to Emmanuele Bassi (:ebassi) from comment #8)
> This problem has been fixed in our software repository. The fix will go into
> the next software release. Once that release is available, you may want to
> check for a software upgrade provided by your Linux distribution.
> 
> Relevant commits:
>  
> https://git.gnome.org/browse/gnome-dictionary/commit/
> ?id=92e9d982ed4014a93f8affa6d69900807ce5ccba
>  
> https://git.gnome.org/browse/gnome-dictionary/commit/
> ?id=679b3b83f35bc8e602f2d3c8b03736e9156fea33
> 
> I've cherry picked them to the 3.24 branch as well.
> 
> I'm going to do a 3.26.1 release by Monday, October 2nd; I'll also do an
> additional 3.24.1 release at that time, so that older distributions can pick
> it up.

Thank you for your work fixing this bug. 
Gnome dictionary is a great app and I really miss the add sources feature for offline dictionaries. 
Thanks :)