GNOME Bugzilla – Bug 762569
Crash on editing an object with no "name"
Last modified: 2016-02-26 06:39:16 UTC
Getting this in the osm-edit-address branch, after changes to a name-less node (just carrying addr: tags). Haven't tested this on master yet (but thought I'd file a bug so I won't forget to investigate this). (gnome-maps:10756): Gtk-WARNING **: gtkliststore.c:836: Unable to convert from gpointer to gchararray (gnome-maps:10756): Gjs-WARNING **: JS ERROR: TypeError: this._place[this._titleProperty] is null PlaceFormatter<.title@resource:///org/gnome/Maps/js/placeFormatter.js:48 PlaceBubble<._populate@resource:///org/gnome/Maps/js/placeBubble.js:118 wrapper@resource:///org/gnome/gjs/modules/lang.js:178 PlaceBubble<._edit/<@resource:///org/gnome/Maps/js/placeBubble.js:273 OSMEditDialog<._onObjectUploaded@resource:///org/gnome/Maps/js/osmEditDialog.js:486 wrapper@resource:///org/gnome/gjs/modules/lang.js:178 OSMConnection<._onChangesetClosed@resource:///org/gnome/Maps/js/osmConnection.js:208 wrapper@resource:///org/gnome/gjs/modules/lang.js:178 OSMConnection<.closeChangeset/<@resource:///org/gnome/Maps/js/osmConnection.js:198 main@resource:///org/gnome/Maps/js/main.js:47 run@resource:///org/gnome/gjs/modules/package.js:192 start@resource:///org/gnome/gjs/modules/package.js:176 @../../install/bin/gnome-maps:5
Sorry to change the summary but I have OCD about summary being kept short and description long. :)
(In reply to Zeeshan Ali (Khattak) from comment #1) > Sorry to change the summary but I have OCD about summary being kept short > and description long. :) No worries! :) I just wanted to quickly jot down the bug, as I found it just when I was about to go to bed after testing editing address information.
… and I think I just realized what the problem is.
Created attachment 322311 [details] [review] osmUtils: Don't update a place's name if not in the OSM object When a place has been edited on OSM don't reset the Place's name attribute if it's not set in the OSM object, since the PlaceFormatter assumes this is set. For bare address nodes, this would be set to a value contructed from the address components, so we shouldn't remove this just because the OSM object doesn't have a name set. This fixes stack trace when saving places like that.
Created attachment 322413 [details] [review] osmUtils: Don't update a place's name if not in the OSM object When a place has been edited on OSM don't reset the Place's name attribute if it's not set in the OSM object, since the PlaceFormatter assumes this is set. For bare address nodes, this would be set to a value contructed from the address components, so we shouldn't remove this just because the OSM object doesn't have a name set. This fixes stack trace when saving places like that.
Review of attachment 322413 [details] [review]: lhtm
Attachment 322413 [details] pushed as 757bafb - osmUtils: Don't update a place's name if not in the OSM object