After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762531 - Show correct tooltip for RDP tab
Show correct tooltip for RDP tab
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: RDP
unspecified
Other Linux
: Normal normal
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-23 12:56 UTC by Marek Kašík
Modified: 2016-02-23 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Show correct tooltip for RDP tab (1.08 KB, patch)
2016-02-23 12:56 UTC, Marek Kašík 		committed Details | Review

Description Marek Kašík 2016-02-23 12:56:48 UTC 
Created attachment 321947 [details] [review]
Show correct tooltip for RDP tab

Vinagre doesn't set correct tooltip for RDP tab once it is initialized. This is caused by not emitting "tab-initialized" signal.
Attached patch emits the signal so the tooltip is set correctly.
Comment 1 David King 2016-02-23 13:43:12 UTC 
Review of attachment 321947 [details] [review]:

::: plugins/rdp/vinagre-rdp-tab.c
@@ +237,3 @@
+  g_signal_emit_by_name (object, "tab-initialized");
+
+  return FALSE;

Use G_SOURCE_REMOVE please (as this is a GSourceFunc).
Comment 2 Marek Kašík 2016-02-23 13:52:13 UTC 
(In reply to David King from comment #1)
> Review of attachment 321947 [details] [review] [review]:
> 
> ::: plugins/rdp/vinagre-rdp-tab.c
> @@ +237,3 @@
> +  g_signal_emit_by_name (object, "tab-initialized");
> +
> +  return FALSE;
> 
> Use G_SOURCE_REMOVE please (as this is a GSourceFunc).

I wanted to but vinagre requires glib 2.28 which doesn't have it. Would you mind if I keep the FALSE there?
Comment 3 David King 2016-02-23 13:54:40 UTC 
(In reply to Marek Kašík from comment #2)
> > Use G_SOURCE_REMOVE please (as this is a GSourceFunc).
> 
> I wanted to but vinagre requires glib 2.28 which doesn't have it. Would you
> mind if I keep the FALSE there?

Please update the GLib requirement to the oldest version with G_SOURCE_REMOVE, then.
Comment 4 Marek Kašík 2016-02-23 14:05:53 UTC 
Comment on attachment 321947 [details] [review]
Show correct tooltip for RDP tab

I've bumped the requirement of GLib to 2.32 and used the G_SOURCE_REMOVE there. It is in master now. Thanks.