GNOME Bugzilla – Bug 762512
Build fails with libcue 2.0
Last modified: 2016-03-21 19:40:31 UTC
Created attachment 321925 [details] [review] patch to fix build against libcue 2.0 libcue 2.0 has been released with two changes that break tracker build - the header file has been moved to the top-level include dir - the Cmt enum has been renamed to RemType The attached patch fixes the build against libcue 2.0, although it will need to be adapted to work with libcue 1.x too.
Created attachment 322585 [details] [review] libcue 2.0 support Updated the patch with conditional support for the 2.0 API changes & configure foo. Tracker should work with the 2.0 version just fine, since the API change is just an enum rename. See https://github.com/lipnitsk/libcue/releases for more info.
Review of attachment 322585 [details] [review]: The PKG_CHECK_EXISTS change looks fine to me. ::: configure.ac @@ +2407,2 @@ AM_CONDITIONAL(HAVE_LIBCUE, test "x$have_libcue" = "xyes") +AM_CONDITIONAL(HAVE_LIBCUE2, test "x$have_libcue2" = "xyes") These automake conditionals are not used; is there any reason to keep them?
Created attachment 322841 [details] [review] libcue 2.0 support You are correct, the conditionals are redundant.
Review of attachment 322841 [details] [review]: Looks good (and builds fine) to me. I'm not a tracker developer, so just marking this as "reviewed".
Looks good to me, too.
Review of attachment 322841 [details] [review]: It should be merged upstream.
Ended up pushing this one. Given I'm in f24/rawhide and affected by the libcue api change, I'll consider this a distcheck fix...