After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762503 - Add libvirt-glib.wxi
Add libvirt-glib.wxi
Status: RESOLVED FIXED
Product: msitools
Classification: Other
Component: general
git
Other Linux
: Normal normal
: 1.0
Assigned To: msitools maintainer(s)
msitools maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-23 00:05 UTC by Fabiano Fidêncio
Modified: 2016-02-23 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wxi: add libvit-glib.wxi (1.57 KB, patch)
2016-02-23 00:05 UTC, Fabiano Fidêncio 		none Details | Review
wxi: add libvirt-glib.wxi (v2) (58.46 KB, patch)
2016-02-23 06:14 UTC, Fabiano Fidêncio 		none Details | Review
wxi: add libvirt-glib.wxi (v3) (58.53 KB, patch)
2016-02-23 13:20 UTC, Fabiano Fidêncio 		committed Details | Review

Description Fabiano Fidêncio 2016-02-23 00:05:15 UTC 
Created attachment 321908 [details] [review]
wxi: add libvit-glib.wxi

See the attached patch.
Comment 1 Marc-Andre Lureau 2016-02-23 01:21:43 UTC 
Why no translations? They should be shipped in all wxi packages, I think we should keep them for now, until we find a common way to disable them (if needed, imho it's not worth the saving)
Comment 2 Fabiano Fidêncio 2016-02-23 06:14:33 UTC 
Created attachment 321920 [details] [review]
wxi: add libvirt-glib.wxi (v2)

Translations added.
I've grep'ed -v the whole lib directory, that's the reason translations got lost in the first patch.
Comment 3 Fabiano Fidêncio 2016-02-23 13:20:18 UTC 
Created attachment 321951 [details] [review]
wxi: add libvirt-glib.wxi (v3)

A "</Directory>" was missing in the v2. Fixed now.
Comment 4 Marc-Andre Lureau 2016-02-23 13:34:12 UTC 
ack v3
Comment 5 Fabiano Fidêncio 2016-02-23 13:42:15 UTC 
Patch pushed as 81426bc and will be part of 0.96 release.