After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762480 - Make location dialog look like mockup
Make location dialog look like mockup
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-22 19:05 UTC by Jonas Danielsson
Modified: 2016-03-11 10:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
location: Style reason label (663 bytes, patch)
2016-03-04 18:05 UTC, Zeeshan Ali 		none Details | Review
location: Replace description w/ privacy note (1.69 KB, patch)
2016-03-04 18:06 UTC, Zeeshan Ali 		committed Details | Review
location: Style reason label (924 bytes, patch)
2016-03-04 18:06 UTC, Zeeshan Ali 		committed Details | Review
Screenshot of the changes (587.10 KB, image/png)
2016-03-09 00:02 UTC, Florian Müllner 		  Details
theme: Actually apply style changes (1.38 KB, patch)
2016-03-11 10:11 UTC, Florian Müllner 		committed Details | Review

Description Jonas Danielsson 2016-02-22 19:05:35 UTC 
The current text is: "Allows your location to be shown on the map."

Any suggestions on what could be a better string?
Comment 1 Allan Day 2016-02-24 15:14:02 UTC 
I think that this is probably a shell bug, actually. The problem isn't so much the text provided as the way it is presented: we need to have a visual hint that the app provided string is different from the other strings in the dialog.

Making the app provided string bold and possibly grey might work.
Comment 2 Zeeshan Ali 2016-03-04 16:41:14 UTC 
New mockup here: https://bug762559.bugzilla-attachments.gnome.org/attachment.cgi?id=322966
Comment 3 Zeeshan Ali 2016-03-04 18:05:29 UTC 
Created attachment 323116 [details] [review]
location: Style reason label

gnome-shell-sass patch.
Comment 4 Zeeshan Ali 2016-03-04 18:06:17 UTC 
Created attachment 323117 [details] [review]
location: Replace description w/ privacy note
Comment 5 Zeeshan Ali 2016-03-04 18:06:23 UTC 
Created attachment 323118 [details] [review]
location: Style reason label
Comment 6 Zeeshan Ali 2016-03-08 22:20:27 UTC 
Florian, once you review them, I'll ask for string freeze break but we really want these in 3.20 I think.
Comment 7 Florian Müllner 2016-03-09 00:02:58 UTC 
Created attachment 323442 [details]
Screenshot of the changes

Attaching screenshot of the updated dialog for a designer ACK ...
Comment 8 Florian Müllner 2016-03-09 00:03:06 UTC 
Review of attachment 323117 [details] [review]:

LG
Comment 9 Florian Müllner 2016-03-09 00:03:17 UTC 
Review of attachment 323118 [details] [review]:

Will need the style changes from the sass patch, otherwise LGTM
Comment 10 Zeeshan Ali 2016-03-10 15:23:26 UTC 
Comment on attachment 323118 [details] [review]
location: Style reason label

Attachment 323118 [details] pushed as 6ccc180 - location: Style reason label
Comment 11 Zeeshan Ali 2016-03-10 15:27:37 UTC 
Attachment 323117 [details] pushed as 64741e4 - location: Replace description w/ privacy note
Comment 12 Florian Müllner 2016-03-11 10:11:23 UTC 
Created attachment 323690 [details] [review]
theme: Actually apply style changes

Commit e86c2826e updated the SASS submodule without actually applying
the changes to the generated CSS.
Comment 13 Florian Müllner 2016-03-11 10:13:06 UTC 
Comment on attachment 323690 [details] [review]
theme: Actually apply style changes

Attachment 323690 [details] pushed as da19924 - theme: Actually apply style changes