GNOME Bugzilla – Bug 762467
Load map layer label doesn't indicate it needs additional input
Last modified: 2018-01-23 02:25:59 UTC
So now it looks like it will trigger something right away. It needs to be called "Load Map Layer..." with three dots after it.
Three dots or unicode equivalent? \u2026? http://www.fileformat.info/info/unicode/char/2026/index.htm
The note from testing day said: "Layers popover: "Load Map Layer" should be "Load Map Layer...". Also, it's a bit ambiguous what this is for." How can we help explain what this is for? Do we have the wrong UI for this? Is it to prominent?
What about: "Open Layer…" The dialog says "Open Layer" and other apps which open a FileChooserDialog use the verb "Open".
picture of other apps: http://i.imgur.com/PkI2U6l.png
Yeah, I think Open Layer makes more sense! Another questions, which I think aday had as well(?) is how do we convey what these layers are? It is not really that known I guess? So it might cause confusion?
So one suggestions... So GeoJSON, KML/Z GPX are quite technical still. Not many casual users will use them or even know what they are... they will at least not seek them out... right? Maybe the button is to prominent an UI, that will cause confusion? The only clue you will get is the file chooser showing it expects .geojson/.kml and so on. ... Maybe we remove the button? Just the button and keep the rest of the UI with showing the layers and the option of hiding them. And since Maps signals it can open the mime-types in the desktop file. Users will still get the suggestion to use Maps to open the file when encountering them on the web and in Nautilus. And it will still be possible to drag the files top Maps. And... we can add a keyboard shortcut to open the file chooser. That will be discoverable through the help overlay. What say? Allan? Hashem? Andreas?
The keyboard shortcut is there now (since 3.26).
I would like to work on this. So, what is it that needs to be done? Changing the button label or removing the button itself?
Created attachment 367165 [details] [review] layers-popover: Change load layer button label Changed the button label to "Open Layer...".
Review of attachment 367165 [details] [review]: ::: data/ui/layers-popover.ui @@ +69,3 @@ <property name="visible">True</property> <property name="can-focus">True</property> + <property name="label" translatable="yes">Open Layer...</property> I think we should stick to using the elipsis character (…) here, as we do in other places. Also see: https://wiki.gnome.org/Initiatives/GnomeGoals/UnicodeUsage
Created attachment 367166 [details] [review] layers-popover: Change load layer button label Added ellipsis character to label.
Review of attachment 367166 [details] [review]: ::: data/ui/layers-popover.ui @@ +69,3 @@ <property name="visible">True</property> <property name="can-focus">True</property> + <property name="label" translatable="yes" comments="Translators: This string uses ellipsis character">Open Layer…</property> Actually, in the keyboard shortcuts help overlay, we show it as "Open shape layer", so maybe the button could be titled "Open Shape Layer…"?
(In reply to Marcus Lundblad from comment #12) > Review of attachment 367166 [details] [review] [review]: > > ::: data/ui/layers-popover.ui > @@ +69,3 @@ > <property name="visible">True</property> > <property name="can-focus">True</property> > + <property name="label" translatable="yes" > comments="Translators: This string uses ellipsis character">Open > Layer…</property> > > Actually, in the keyboard shortcuts help overlay, we show it as "Open shape > layer", so maybe the button could be titled "Open Shape Layer…"? I totally agree with that. Even I checked the various files associated with this feature and everywhere we show it as "shape layer". However, in the shape-layer-file-chooser file the file chooser dialog box title says "Open Layer". I think that should also be changed to something like "Open Shape Layer" or "Choose Shape Layer".
Created attachment 367196 [details] [review] layers-popover: Change load layer button label Changed to "Open Shape Layer…". Maybe I should've discussed this but I've also made changes to the shape-layer-file-chooser file and changed title to "Choose Shape Layer". If you don't like the change I will amend it.
Review of attachment 367196 [details] [review]: I think this patch was a diff from the last patch, you should amend the previous patch (and obsolete it, git-bz can do it automagically). Also, we have mostly used "initial-lower-case-camel-case" for the module name (similar to the JS source files), like the style usually used for JavaScript function or Java method names, so in this case: layersPopover ::: data/ui/shape-layer-file-chooser.ui @@ +2,3 @@ <interface> <template class="Gjs_ShapeLayerFileChooser" parent="GtkFileChooserDialog"> + <property name="title" translatable="yes">Choose Shape Layer</property> I think I prefer "Open Shape Layer" here, to be consistent with the label of the button and the label in the help overview.
Created attachment 367207 [details] [review] layersPopover: Change load map layer button label Changed "Open Layer" to "Open Shape Layer" in shape-layer-file-chooser file and changed the file name format.
Review of attachment 367207 [details] [review]: LGTM
Attachment 367207 [details] pushed as 44772fd - layersPopover: Change load map layer button label
Commited now, thanks for the patch!
(In reply to Marcus Lundblad from comment #19) > Commited now, thanks for the patch! I made a lot of mistakes, thanks for guiding me with this.