After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762381 - User should be able to notice new tabs when opened from history
User should be able to notice new tabs when opened from history
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: History
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-20 20:21 UTC by Michael Catanzaro
Modified: 2016-02-24 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Focus the new tab when opening a page from history (1.47 KB, patch)
2016-02-23 16:20 UTC, Gabriel Ivașcu 		none Details | Review
Focus the new tab when opening a page from history (1.09 KB, patch)
2016-02-23 23:27 UTC, Gabriel Ivașcu 		committed Details | Review

Description Michael Catanzaro 2016-02-20 20:21:35 UTC 
Opening a web page from history should open the new tab one position to the right of the currently-focused tab, not in the rightmost position in the notebook.
Comment 1 Michael Catanzaro 2016-02-22 21:37:53 UTC 
Actually, the issue here is not so much where the tab is opened, but that the tab is not focused: it opens on the far right and the user has no way to notice, and thinks it did not open at all.
Comment 2 Gabriel Ivașcu 2016-02-23 16:20:52 UTC 
Created attachment 322001 [details] [review]
Focus the new tab when opening a page from history

(In reply to Michael Catanzaro from comment #1)
> Actually, the issue here is not so much where the tab is opened, but that
> the tab is not focused: it opens on the far right and the user has no way to
> notice, and thinks it did not open at all.

I believe this should fix the focus problem.
Comment 3 Michael Catanzaro 2016-02-23 19:52:21 UTC 
Review of attachment 322001 [details] [review]:

Works perfectly, thanks!

::: src/ephy-history-window.c
@@ +390,2 @@
 		embed = ephy_shell_new_tab (ephy_shell_get_default (),
+					    window, NULL, flags);

Just pass EPHY_NEW_TAB_JUMP directly, no need for the local variable.

@@ +521,2 @@
 	embed = ephy_shell_new_tab (ephy_shell_get_default (),
+				    window, NULL, flags);

Ditto.
Comment 4 Gabriel Ivașcu 2016-02-23 23:27:28 UTC 
Created attachment 322187 [details] [review]
Focus the new tab when opening a page from history

(In reply to Michael Catanzaro from comment #3)
> Just pass EPHY_NEW_TAB_JUMP directly, no need for the local variable.

Okay, did it.
Comment 5 Michael Catanzaro 2016-02-24 00:06:41 UTC 
Review of attachment 322187 [details] [review]:

Great!
Comment 6 Michael Catanzaro 2016-02-24 19:18:53 UTC 
Attachment 322187 [details] pushed as 33a5e04 - Focus the new tab when opening a page from history