After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762367 - Use a single progress bar for the whole of the internal copy operation
Use a single progress bar for the whole of the internal copy operation
Status: RESOLVED FIXED
Product: gparted
Classification: Other
Component: application
GIT HEAD
Other Linux
: Normal enhancement
: ---
Assigned To: Mike Fleetwood
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2016-02-20 09:47 UTC by Mike Fleetwood
Modified: 2016-04-26 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Single internal copy progress bar (v1) (6.05 KB, patch)
2016-02-20 10:19 UTC, Mike Fleetwood
none Details | Review

Description Mike Fleetwood 2016-02-20 09:47:03 UTC
As part of the internal block copy operation 5 initial ranges of blocks
are copied using different block sizes to determine the fastest.  Then
the remainder is copied using the fastest block size.  Each of these
copies reports progress independently, so during the benchmarking phase
the progress bar flashes 5 times, before showing the progress of the
remainder.  This looks bad.

I'll fix this while dealing with progress bars is fresh in my mind.
Comment 1 Mike Fleetwood 2016-02-20 10:19:49 UTC
Created attachment 321710 [details] [review]
Single internal copy progress bar (v1)

Hi Curtis,

Here's the small patchset for this.

Thanks,
Mike
Comment 2 Curtis Gedak 2016-02-23 18:03:34 UTC
Thank you Mike for this enhancement to improve the way the copy progress bar works.

I successfully tested patch v1 from comment #1 on the following distros:

  debian  8
  fedora 22
 kubuntu 12.04
openSUSE 13.2

Patch v1 has been committed to the git repository for inclusion in the next
release of GParted.

The relevant git commit can be viewed at the following link:

Update internal block copy, total_done after last progress report (#762367)
https://git.gnome.org/browse/gparted/commit/?id=2f2280e3d582cecb1163e56c0f299f0b1c673c69

Use a single progress bar for the internal block copy operation (#762367)
https://git.gnome.org/browse/gparted/commit/?id=1358a5f4fe3bd8c5e5263f4b99d129cb8a64ae3d
Comment 3 Curtis Gedak 2016-04-26 15:55:41 UTC
This enhancement was included in the GParted 0.26.0 release on April 26, 2016.