After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762333 - ensure autoconnection does not make a device !NM_UNMANAGED_USER_EXPLICT
ensure autoconnection does not make a device !NM_UNMANAGED_USER_EXPLICT
Status: RESOLVED WONTFIX
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-1-2
 
 
Reported: 2016-02-19 15:42 UTC by Thomas Haller
Modified: 2016-02-22 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-02-19 15:42:42 UTC 
When the user explicitly sets the managed flag of a device, we set it NM_UNMANAGED_USER_EXPLICT.

Also, when the user activates a a device, we set it. That is necessary, because a device might be unmanaged for reason NM_UNMANAGED_USER_UDEV. This can be overturned by an explicit user-request therefore we must record this by setting the flag.


Autoconnect should not set the USER_EXPLICIT flags (also because autoconnect is only possible if no other unmanaged-flags prevent autoactivation).


Ensure that autoconnect does not cause USER_EXPLICIT to be set.
Comment 1 Thomas Haller 2016-02-22 16:41:14 UTC 
This is not easily fixable, because NMPolicy calls nm_manager_activate_connection() for autoactivation.

But there are other reasons why nm_manager_activate_connection() is called -- e.g. when a slave activates it's master


I think now, it's correct that also autoactivation makes a device explicitly-managed. autoactivation can only happen after a device is already managed, once we (auto)activate a connection on the device, we already took full control of the device and manage it. That is what NM_UNMANAGED_USER_EXPLICIT means.