After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762275 - Post review dialog - color the stars to indicate selection
Post review dialog - color the stars to indicate selection
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-18 16:27 UTC by Allan Day
Modified: 2016-02-18 19:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Allan Day 2016-02-18 16:27:26 UTC 
Right now different icons (starred-symbolic and non-starred) are used to indicate the star selection. This doesn't look all that great.

It would be better to always used starred-symbolic, and change the color to indicate the selection, like in the mockups:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/software/version3/app-page.png

The color is $selected_bg_color.
Comment 1 Allan Day 2016-02-18 16:37:48 UTC 
We might want to use color to indicate star ratings elsewhere, too (like in the app detail pages themselves).
Comment 2 Richard Hughes 2016-02-18 19:26:06 UTC 
commit eb89ddc8e47aac4e0a6d2f25d96210d99d6ea30f
Author: Richard Hughes <richard@hughsie.com>
Date:   Thu Feb 18 19:09:26 2016 +0000

    Use the selected background color for the sensitive star ratings
    
    In the details shell we use the 'insensitive' style which uses monochrome
    styling and in the review dialog (which is clickable and sensitive) we use
    larger colorful stars.
    
    We also no longer award 'half-stars' and round to the nearest whole star.
    
    Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=762275