GNOME Bugzilla – Bug 762266
dist tarball is missing SVG files
Last modified: 2016-02-22 09:29:47 UTC
When running "make install" using the 3.18.1 dist tarball, I get the following error messages: /usr/bin/install: cannot stat './maki/scalable_places_poi-school.svg': No such file or directory INSTALL /home/michael/debian/build-area/geocode-glib-3.18.1/debian/tmp//usr/share/icons/gnome/scalable/places/poi-place-of-worship.svg /usr/bin/install: cannot stat './maki/scalable_places_poi-place-of-worship.svg': No such file or directory INSTALL /home/michael/debian/build-area/geocode-glib-3.18.1/debian/tmp//usr/share/icons/gnome/scalable/places/poi-restaurant.svg /usr/bin/install: cannot stat './maki/scalable_places_poi-restaurant.svg': No such file or directory INSTALL /home/michael/debian/build-area/geocode-glib-3.18.1/debian/tmp//usr/share/icons/gnome/scalable/places/poi-bar.svg /usr/bin/install: cannot stat './maki/scalable_places_poi-bar.svg': No such file or directory Those files are indeed missing from the tarball: [michael@pluto geocode-glib-3.18.1]$ find icons/ -name *.svg icons/maki/scalable_places_poi-building.svg icons/maki/scalable_places_poi-airport.svg icons/maki/scalable_places_poi-town.svg icons/maki/scalable_places_poi-bus-stop.svg icons/maki/scalable_places_poi-railway-station.svg icons/maki/scalable_places_poi-marker.svg icons/maki/scalable_places_poi-car.svg They are in the git repository though: [michael@pluto geocode-glib (gnome-3-18)]$ find icons/ -name *.svg icons/maki/scalable_places_poi-building.svg icons/maki/scalable_places_poi-airport.svg icons/maki/scalable_places_poi-bar.svg icons/maki/scalable_places_poi-town.svg icons/maki/scalable_places_poi-bus-stop.svg icons/maki/scalable_places_poi-school.svg icons/maki/scalable_places_poi-railway-station.svg icons/maki/scalable_places_poi-marker.svg icons/maki/scalable_places_poi-place-of-worship.svg icons/maki/scalable_places_poi-restaurant.svg icons/maki/scalable_places_poi-car.svg So this looks like icons/Makefile.am's EXTRA_DIST is incomplete. diff --git a/icons/Makefile.am b/icons/Makefile.am index 6d78068..c2b3e2c 100644 --- a/icons/Makefile.am +++ b/icons/Makefile.am @@ -53,5 +53,10 @@ EXTRA_DIST = \ maki/scalable_places_poi-marker.svg \ maki/scalable_places_poi-railway-station.svg \ maki/scalable_places_poi-town.svg + maki/scalable_places_poi-school.svg \ + maki/scalable_places_poi-place-of-worship.svg \ + maki/scalable_places_poi-restaurant.svg \ + maki/scalable_places_poi-bar.svg \ + maki/scalable_places_poi-airport.svg -include $(top_srcdir)/git.mk
Thanks! I pushed a 3.18.2 with correct EXTRA_DIST!
Thanks for the quick fix. I like your solution, as now EXTRA_DIST and public_icons won't get out-of-sync anymore.