After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762259 - rtpjitterbuffer: Add RFC7273 media clock handling
rtpjitterbuffer: Add RFC7273 media clock handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-18 11:22 UTC by Sebastian Dröge (slomo)
Modified: 2016-04-03 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
WIP: rtpjitterbuffer: Add RFC7273 media clock handling (18.66 KB, patch)
2016-02-18 11:22 UTC, Sebastian Dröge (slomo) 		needs-work Details | Review
rtpjitterbuffer: Add RFC7273 media clock handling (37.01 KB, patch)
2016-02-22 15:52 UTC, Sebastian Dröge (slomo) 		none Details | Review
rtpjitterbuffer: Add RFC7273 media clock handling (37.11 KB, patch)
2016-02-22 17:40 UTC, Sebastian Dröge (slomo) 		none Details | Review
rtpjitterbuffer: Add RFC7273 media clock handling (37.03 KB, patch)
2016-02-22 17:55 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-02-18 11:22:03 UTC 
See commit message
Comment 1 Sebastian Dröge (slomo) 2016-02-18 11:22:07 UTC 
Created attachment 321578 [details] [review]
WIP: rtpjitterbuffer: Add RFC7273 media clock handling
Comment 2 Sebastian Dröge (slomo) 2016-02-22 15:52:04 UTC 
Created attachment 321855 [details] [review]
rtpjitterbuffer: Add RFC7273 media clock handling
Comment 3 Sebastian Dröge (slomo) 2016-02-22 17:40:42 UTC 
Created attachment 321873 [details] [review]
rtpjitterbuffer: Add RFC7273 media clock handling
Comment 4 Sebastian Dröge (slomo) 2016-02-22 17:55:20 UTC 
Created attachment 321878 [details] [review]
rtpjitterbuffer: Add RFC7273 media clock handling
Comment 5 Sebastian Dröge (slomo) 2016-03-24 13:25:54 UTC 
Review of attachment 321878 [details] [review]:

::: gst/rtpmanager/rtpjitterbuffer.c
@@ +900,3 @@
+      nsrtptimediff = 0;
+
+    rtpntptime = nsrtptimediff + jbuf->media_clock_base_time;

It might make sense to update the base times here every now and then, e.g. to the average of all in the last 10 seconds or something. Otherwise we will have a base in the past, and small inaccuracies in the netclock sync will result in huge differences as the distance from the base is big.
Comment 6 Sebastian Dröge (slomo) 2016-04-03 08:24:56 UTC 
Attachment 321878 [details] pushed as df247f0 - rtpjitterbuffer: Add RFC7273 media clock handling