After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762251 - Scroll to the file that is going to be renamed
Scroll to the file that is going to be renamed
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: All
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 761721 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-02-18 08:55 UTC by Carlos Soriano
Modified: 2018-06-17 00:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Carlos Soriano 2016-02-18 08:55:05 UTC 
When the rename popover opens.

Seems we are not making sure to scroll to that point, which is inconvenient.Nautilus
Comment 1 Razvan Chitu 2016-02-20 23:27:35 UTC 
(In reply to Carlos Soriano from comment #0)
> When the rename popover opens.
> 
> Seems we are not making sure to scroll to that point, which is
> inconvenient.Nautilus

I'm guessing 'nautilus_files_view_scroll_to_file' should be used to fix this. I tried using it and sometimes it works, sometimes it doesn't. For example, using it before 'nautilus_files_view_rename_file_popover_new' in list-view makes the UI freeze. Any idea what might cause this?
Comment 2 Carlos Soriano 2016-02-21 22:44:18 UTC 
(In reply to Razvan Chitu from comment #1)
> (In reply to Carlos Soriano from comment #0)
> > When the rename popover opens.
> > 
> > Seems we are not making sure to scroll to that point, which is
> > inconvenient.Nautilus
> 
> I'm guessing 'nautilus_files_view_scroll_to_file' should be used to fix
> this. I tried using it and sometimes it works, sometimes it doesn't. For
> example, using it before 'nautilus_files_view_rename_file_popover_new' in
> list-view makes the UI freeze. Any idea what might cause this?

indeed :) I was pondering for some time if this bug was really for newcomers.
It is if you are willing to spend time debugging... basically this bug is good to learn how the management of "views/slot/loading of directories in the views" works, which is the most important and complex in the UI side.

Track the load_directory and done_loading functions. Track also the invalidation of the selection and the display_new_files functions, that also clear the selection iirc.
Then find at what time it should be called, or if it is a bug because some of that functions shouldn't clear the selection at some specific time.
Comment 3 Adhityaa Chandrasekar 2016-02-27 21:08:13 UTC 
Does the whole view need to move up/down to the highlighted file? I feel it shouldn't because the user would lose track of his current position. (Plus he doesn't see any new information by moving up/down to the highlighted file. We can just show the rename box which will have the file name pre-filled - this is the same information even if we move up/down.)
Comment 4 António Fernandes 2017-08-28 11:57:25 UTC 
*** Bug 761721 has been marked as a duplicate of this bug. ***
Comment 5 Jan Niklas Hasse (Account disabled) 2017-08-28 12:09:55 UTC 
> Plus he doesn't see any new information by moving up/down to the highlighted file.

He does see new information: The file's icon and details (depending on the view) and also the files / folders around it.