After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762249 - Don't use gtk_tree_view_set_rules_hint
Don't use gtk_tree_view_set_rules_hint
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-18 08:51 UTC by Carlos Soriano
Modified: 2016-03-01 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove gtk_tree_view_set_rules_hint(deprecated) (970 bytes, patch)
2016-02-18 20:00 UTC, Alexandru Pandelea 		reviewed Details | Review
Don't use gtk_tree_view_set_rules_hint (1.06 KB, patch)
2016-02-29 15:23 UTC, Alexandru Pandelea 		reviewed Details | Review
list-view: don't use gtk_tree_view_set_rules_hint (1.08 KB, patch)
2016-02-29 17:14 UTC, Alexandru Pandelea 		committed Details | Review

Description Carlos Soriano 2016-02-18 08:51:55 UTC 
It's deprecated
Comment 1 Alexandru Pandelea 2016-02-18 20:00:06 UTC 
Created attachment 321614 [details] [review]
Remove gtk_tree_view_set_rules_hint(deprecated)

https://bugzilla.gnome.org/show_bug.cgi?id=762249ZZZZ
Comment 2 Carlos Soriano 2016-02-29 14:41:21 UTC 
Review of attachment 321614 [details] [review]:

the deprecated should be in the description. The title says what you did, the descriptions explains why. (also the title would be too long otherwise).
Also explain why removing it it's ok.

Also, the bug report link in the description is wrong, it has ZZZZ at the end (did you fall sleep? :))
Comment 3 Alexandru Pandelea 2016-02-29 14:43:12 UTC 
yeah...I don't know how that happened, I'll update it:))
Comment 4 Alexandru Pandelea 2016-02-29 15:23:15 UTC 
Created attachment 322668 [details] [review]
Don't use gtk_tree_view_set_rules_hint

The reason why gtk_tree_view_set_rules_hint was removed is
that it is deprecated. It was not replaced at is no longer
needed.
Comment 5 Carlos Soriano 2016-02-29 15:44:57 UTC 
Review of attachment 322668 [details] [review]:

put the file name in the title.
Also, it doesn't explain why it is not needed. It is not needed because themes can just do it with CSS.
Comment 6 Alexandru Pandelea 2016-02-29 17:14:34 UTC 
Created attachment 322681 [details] [review]
list-view: don't use gtk_tree_view_set_rules_hint

The reason why gtk_tree_view_set_rules_hint was removed is that it is
deprecated. It is not needed anymore as themes can do this with CSS.
Comment 7 Carlos Soriano 2016-03-01 14:27:48 UTC 
Review of attachment 322681 [details] [review]:

Looks good now, thanks!
Comment 8 Carlos Soriano 2016-03-01 14:31:40 UTC 
Attachment 322681 [details] pushed as adcb152 - list-view: don't use gtk_tree_view_set_rules_hint