GNOME Bugzilla – Bug 762243
Don't use gtk_status_icon_set_visible
Last modified: 2016-04-22 13:58:03 UTC
Since it's deprecated. Find a replacement
And forgot to say, all the gtk_status_* functions!
update on this. We actually assume where nautilus is running supports freedesktop notifications, so we can remove all the handling of systray icons, and therefore remove these funtions of gtk_status*.
Created attachment 324935 [details] [review] Remove system tray icon handling This patch removes any mention of systray icons in the progress persistence handler. I left the checks for persistence in, FWIW.
Review of attachment 324935 [details] [review]: Looks good so far, just missing some safe guards when the persistence is not present. Also the commit message doesn't follow very well the commit guidelines. Look at https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines ::: src/nautilus-progress-persistence-handler.c @@ +57,2 @@ * - when one file operation finishes, if it's not the last one, we only update the + * resident notification's message format the comment @@ +151,2 @@ static void +progress_persistence_handler_hide_notification (NautilusProgressPersistenceHandler *self) Missing safe guard
Created attachment 324993 [details] [review] Proposed patch v3
Created attachment 324994 [details] [review] Proposed patch v4 Forgot to include the safeguard.
Review of attachment 324994 [details] [review]: Now code looks good, and commit message much better. The commit message still lacks the file you modified "persistence-handler" in the title. See the commit messages guidelines. Also, worth to mention in your last paragraph that we expect all DE that will use a nautilus as new as 3.22 to support persistence, and that's why we can safely remove it.
Created attachment 324998 [details] [review] Proposed patch v5 Ideally, this would be a one-shot deal. I now hope to not surpass five. :)
Any update on this?
Review of attachment 324998 [details] [review]: Whops, not sure why this bug emails goes to my spam folder and looked at it today by chance :/ Anyway, looks good now thanks! Feel free to ping me on IRC when I forgot about reviewing something.