After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762241 - Don't use gtk_message_dialog_set_image and use GtkDialog
Don't use gtk_message_dialog_set_image and use GtkDialog
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-18 08:42 UTC by Carlos Soriano
Modified: 2016-04-14 09:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (5.05 KB, patch)
2016-03-28 17:04 UTC, Ernestas Kulik
none Details | Review
Remove image from the autorun dialog (1.35 KB, patch)
2016-03-29 08:26 UTC, Ernestas Kulik
none Details | Review
Proposed patch v3 (1.47 KB, patch)
2016-03-30 10:35 UTC, Ernestas Kulik
none Details | Review
Proposed patch v4 (1.50 KB, patch)
2016-03-30 11:18 UTC, Ernestas Kulik
accepted-commit_now Details | Review

Description Carlos Soriano 2016-02-18 08:42:32 UTC
It's deprecated and not really needed.
Comment 1 Ernestas Kulik 2016-03-28 17:04:30 UTC
Created attachment 324880 [details] [review]
Proposed patch

With this, the autorun dialog still looks like a GtkMessageDialog, but has a large forehead instead of a belly.
Comment 2 Carlos Soriano 2016-03-29 08:12:59 UTC
Review of attachment 324880 [details] [review]:

Thanks for the patch!

However, the dialog looks much different. It has its button on a header bar instead of in the bottom as dialog usually have them. We want to keep the look of a normal dialog.

Also, in this case as I said in the first comment, this is "not really needed", as in, we can remove the image from the dialog.

So the patch is just removing one line afaics.
Comment 3 Ernestas Kulik 2016-03-29 08:26:27 UTC
Created attachment 324932 [details] [review]
Remove image from the autorun dialog

Whoops, my bad. This should take care of it, then.
Comment 4 Ernestas Kulik 2016-03-30 10:35:49 UTC
Created attachment 325001 [details] [review]
Proposed patch v3

Touched up the commit message.
Comment 5 Carlos Soriano 2016-03-30 11:12:32 UTC
Review of attachment 325001 [details] [review]:

Can you explain why the image isn't necessary in the commit message? It doesn't communicate properly why.
(in case you don't know, it's simply that we no longer recommend to put images on the dialog, since in this case doesn't communicate any important information)
Comment 6 Ernestas Kulik 2016-03-30 11:18:15 UTC
Created attachment 325003 [details] [review]
Proposed patch v4
Comment 7 Carlos Soriano 2016-03-30 11:29:39 UTC
Review of attachment 325003 [details] [review]:

LGTM now thanks!