GNOME Bugzilla – Bug 762241
Don't use gtk_message_dialog_set_image and use GtkDialog
Last modified: 2016-04-14 09:58:11 UTC
It's deprecated and not really needed.
Created attachment 324880 [details] [review] Proposed patch With this, the autorun dialog still looks like a GtkMessageDialog, but has a large forehead instead of a belly.
Review of attachment 324880 [details] [review]: Thanks for the patch! However, the dialog looks much different. It has its button on a header bar instead of in the bottom as dialog usually have them. We want to keep the look of a normal dialog. Also, in this case as I said in the first comment, this is "not really needed", as in, we can remove the image from the dialog. So the patch is just removing one line afaics.
Created attachment 324932 [details] [review] Remove image from the autorun dialog Whoops, my bad. This should take care of it, then.
Created attachment 325001 [details] [review] Proposed patch v3 Touched up the commit message.
Review of attachment 325001 [details] [review]: Can you explain why the image isn't necessary in the commit message? It doesn't communicate properly why. (in case you don't know, it's simply that we no longer recommend to put images on the dialog, since in this case doesn't communicate any important information)
Created attachment 325003 [details] [review] Proposed patch v4
Review of attachment 325003 [details] [review]: LGTM now thanks!