After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762238 - Stop using gtk_alignment_new and use widget properties instead
Stop using gtk_alignment_new and use widget properties instead
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-18 08:37 UTC by Carlos Soriano
Modified: 2016-05-02 16:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for properties-window (2.54 KB, patch)
2016-04-07 13:26 UTC, Ernestas Kulik 		committed Details | Review
Patch for list-view (1.62 KB, patch)
2016-04-07 13:27 UTC, Ernestas Kulik 		committed Details | Review
Patch for file-conflict-dialog (2.22 KB, patch)
2016-04-17 09:45 UTC, Ernestas Kulik 		committed Details | Review

Description Carlos Soriano 2016-02-18 08:37:23 UTC 
The former is deprecated!
Comment 1 Ernestas Kulik 2016-04-07 13:26:41 UTC 
Created attachment 325531 [details] [review]
Patch for properties-window
Comment 2 Ernestas Kulik 2016-04-07 13:27:06 UTC 
Created attachment 325532 [details] [review]
Patch for list-view
Comment 3 Carlos Soriano 2016-04-08 12:21:23 UTC 
Review of attachment 325531 [details] [review]:

LGTM thanks!
Comment 4 Carlos Soriano 2016-04-08 12:23:59 UTC 
Review of attachment 325532 [details] [review]:

Nice!
Comment 5 Ernestas Kulik 2016-04-17 09:45:09 UTC 
Created attachment 326185 [details] [review]
Patch for file-conflict-dialog

My bad, seems that I forgot to look outside src/. Should be the last of GtkAlignment now.
Comment 6 Carlos Soriano 2016-04-18 21:05:26 UTC 
Review of attachment 326185 [details] [review]:

LGTM thanks!
Comment 7 Ernestas Kulik 2016-04-30 08:35:53 UTC 
Sorry for resurrecting this, but just making sure you don’t miss that last patch.
Comment 8 Carlos Soriano 2016-05-02 06:35:10 UTC 
(In reply to Ernestas Kulik from comment #7)
> Sorry for resurrecting this, but just making sure you don’t miss that last
> patch.

You mean I committed the first two patches and not the last one?

Actually this looks like a mistake with git bz. I can only see I committed the first one, but not with git bz (in that case the commit will appear here) not the others two.

Not sure what happened, but good that you caught this. Please feel free to commit them :)
Comment 9 Ernestas Kulik 2016-05-02 16:13:36 UTC 
Attachment 326185 [details] pushed as 470235f - file-conflict-dialog: use widget properties instead of GtkAlignment