After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762234 - Port thumbnails creation from pthread to Gtask
Port thumbnails creation from pthread to Gtask
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Thumbnails
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 760468 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-02-18 08:28 UTC by Carlos Soriano
Modified: 2016-03-17 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
thumbnails: replace pthread API with GTask and GThread (6.05 KB, patch)
2016-02-19 08:35 UTC, Razvan Chitu 		none Details | Review
thumbnails: replace pthread API with GTask and GThread (6.08 KB, patch)
2016-02-26 10:01 UTC, Razvan Chitu 		committed Details | Review

Description Carlos Soriano 2016-02-18 08:28:33 UTC 
So we will have better threading support.https://bugzilla.gnome.org/show_bug.cgi?id=762137
Comment 1 Razvan Chitu 2016-02-19 08:35:09 UTC 
Created attachment 321635 [details] [review]
thumbnails: replace pthread API with GTask and GThread

In Nautilus, thumbnail creation is handled on a separate thread. This thread is
created and managed using the POSIX threads API. For better threading support,
GTask and GThread should be used instead.

Replace the pthread with a GTask. Replace pthread_mutex with GMutex.
Comment 2 Razvan Chitu 2016-02-19 16:50:13 UTC 
Also, isn't this a duplicate of https://bugzilla.gnome.org/show_bug.cgi?id=760468?
Comment 3 Carlos Soriano 2016-02-26 07:48:36 UTC 
Review of attachment 321635 [details] [review]:

/me dancing

Looks mostly good, thanks!

::: libnautilus-private/nautilus-thumbnails.c
@@ +452,3 @@
+                       gpointer source_object,
+                       gpointer task_data,
+                       GCancellable *cancellable)

wrong ident
Comment 4 Carlos Soriano 2016-02-26 07:49:04 UTC 
*** Bug 760468 has been marked as a duplicate of this bug. ***
Comment 5 Razvan Chitu 2016-02-26 10:01:51 UTC 
Created attachment 322444 [details] [review]
thumbnails: replace pthread API with GTask and GThread

In Nautilus, thumbnail creation is handled on a separate thread. This thread is
created and managed using the POSIX threads API. For better threading support,
GTask and GThread should be used instead.

Replace the pthread with a GTask. Replace pthread_mutex with GMutex.
Comment 6 Carlos Soriano 2016-02-26 15:53:27 UTC 
Review of attachment 322444 [details] [review]:

LGTM thanks!
Comment 7 Razvan Chitu 2016-02-29 17:25:03 UTC 
Attachment 322444 [details] pushed as b2ee410 .