After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762229 - vaapisink: Fix event,pad memory leaks
vaapisink: Fix event,pad memory leaks
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-18 01:15 UTC by Vineeth
Modified: 2016-02-18 07:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix memory leak (1.20 KB, patch)
2016-02-18 01:16 UTC, Vineeth 		none Details | Review
fix memory leaks (1.26 KB, patch)
2016-02-18 02:31 UTC, Vineeth 		committed Details | Review

Description Vineeth 2016-02-18 01:15:19 UTC 
If sink->window is not present, then we are just returning without performing any operation. But memory is getting allocated for event and peer.

Hence moving the check to the beginning before allocations.
Comment 1 Vineeth 2016-02-18 01:16:18 UTC 
Created attachment 321555 [details] [review]
fix memory leak
Comment 2 Vineeth 2016-02-18 02:31:46 UTC 
Created attachment 321557 [details] [review]
fix memory leaks

Free structure as well on returning.
Comment 3 Thiago Sousa Santos 2016-02-18 07:08:03 UTC 
commit 24bc53456c118ce0960adb6aa958861b599a56ad
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Thu Feb 18 10:13:53 2016 +0900

    vaapisink: Fix event,pad,structure memory leaks
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762229