After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762228 - Icon view broken in Adwaita dark, view preferences ignored
Icon view broken in Adwaita dark, view preferences ignored
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: Icon View
3.19.x
Other Linux
: Normal major
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-18 01:08 UTC by ar
Modified: 2016-03-02 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
misrendered list-view with adwaita dark (23.72 KB, image/png)
2016-02-18 01:08 UTC, ar
  Details
Adwaita.css: Fix dark theme background (1003 bytes, patch)
2016-03-02 13:31 UTC, Alexandru Pandelea
committed Details | Review

Description ar 2016-02-18 01:08:41 UTC
Created attachment 321554 [details]
misrendered list-view with adwaita dark

This is probably two bugs, but they appeared at the same time. (nautilus a464da1e, gtk: 0298d50)

1. With dark Adwaita (gtk-application-prefer-dark-theme = true) the icon view is broken: Background is rendered all white (as, or at least I think, in Adwaita vanilla) and so are the names unless selected, see screenshot.

2. Nautilus now instantly forgets the view preference. If I open dconf-editor, go to its preferences and set default-folder-viewer to the offered list_view (plus delete ~/.local/share/gvfs-metadata and pkill -9 nautilus for good measure), I can actually watch it being reset to icon-view upon opening any other folder after nautilus's start.
Comment 1 Carlos Soriano 2016-02-18 09:18:56 UTC
Please report bugs in different bug reports. Let's use this one for the one in the title.

This needs in CSS to use theme vars.
Comment 2 Alexandru Pandelea 2016-03-02 13:31:47 UTC
Created attachment 322854 [details] [review]
Adwaita.css: Fix dark theme background

The problem was that when the theme was switched from Adwaita light to Adwaita
dark, the background was kept on white.

The solution was to switch from the white background color, that was always
set for Adwaita to the corresponding theme_base_color of the theme.
Comment 3 Carlos Soriano 2016-03-02 15:39:32 UTC
Review of attachment 322854 [details] [review]:

yep thanks!
Comment 4 Carlos Soriano 2016-03-02 15:40:31 UTC
Attachment 322854 [details] pushed as 044c4ec - Adwaita.css: Fix dark theme background