After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762217 - rtpsession: Add new signal 'on-app-rtcp'
rtpsession: Add new signal 'on-app-rtcp'
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 761944
Blocks:
 
 
Reported: 2016-02-17 19:12 UTC by Håvard Graff (hgr)
Modified: 2019-06-13 00:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
implementation with test (7.06 KB, patch)
2016-02-17 19:12 UTC, Håvard Graff (hgr) 		needs-work Details | Review
Patch rebased on top of master (7.18 KB, patch)
2016-03-30 08:23 UTC, Stian Selnes (stianse) 		committed Details | Review

Description Håvard Graff (hgr) 2016-02-17 19:12:22 UTC 
Created attachment 321538 [details] [review]
implementation with test

Similar to the 'on-feedback-rtcp' signal, but emitted for RTCP APP
packets.
Comment 1 Olivier Crête 2016-03-16 23:01:05 UTC 
Comment on attachment 321538 [details] [review]
implementation with test

Also looks good to me
Comment 2 Sebastian Dröge (slomo) 2016-03-24 12:33:34 UTC 
Comment on attachment 321538 [details] [review]
implementation with test

Does not apply to latest master
Comment 3 Stian Selnes (stianse) 2016-03-30 08:23:37 UTC 
Created attachment 324991 [details] [review]
Patch rebased on top of master

rtpsession: Add new signal 'on-app-rtcp'

Similar to the 'on-feedback-rtcp' signal, but emitted for RTCP APP
packets.
Comment 4 Sebastian Dröge (slomo) 2016-03-30 12:44:31 UTC 
commit 4c0e50932863fdeed376d92e92946e282ba9eab2
Author: Stian Selnes <stian@pexip.com>
Date:   Tue Nov 17 18:17:35 2015 +0100

    rtpsession: Add new signal 'on-app-rtcp'
    
    Similar to the 'on-feedback-rtcp' signal, but emitted for RTCP APP
    packets.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762217
Comment 5 Aaron Boxer 2019-06-12 23:46:56 UTC 
Why is the subtype of the packet sent to callback, but not the type of the packet ?
Comment 6 Aaron Boxer 2019-06-12 23:47:26 UTC 
I could really use the packet type :)
Comment 7 Aaron Boxer 2019-06-12 23:47:57 UTC 
Also, this new signal unfortunately doesn't get displayed by gst-inspect
Comment 8 Nicolas Dufresne (ndufresne) 2019-06-13 00:01:29 UTC 
Because the type is always the same, APP.
Comment 9 Aaron Boxer 2019-06-13 00:30:52 UTC 
of course ! :) Thanks