After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762214 - jitterbuffer: Fix leaks in test
jitterbuffer: Fix leaks in test
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.7.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 762267
 
 
Reported: 2016-02-17 18:55 UTC by Håvard Graff (hgr)
Modified: 2016-02-19 12:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.36 KB, patch)
2016-02-17 18:55 UTC, Håvard Graff (hgr)
committed Details | Review

Description Håvard Graff (hgr) 2016-02-17 18:55:23 UTC
Created attachment 321535 [details] [review]
patch

Preventing them from passing in valgrind!
Comment 1 Tim-Philipp Müller 2016-02-19 11:12:56 UTC
Not sure a leak in a unit test is 'critical' :)

Thanks for the patch!

commit fb4c2909ca7844b8def2a5cf4c58a9c099676da6
Author: Stian Selnes <stian@pexip.com>
Date:   Thu Dec 3 11:07:05 2015 +0100

    tests: rtpjitterbuffer: fix leaks in unit test
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762214
Comment 2 Håvard Graff (hgr) 2016-02-19 12:15:40 UTC
(In reply to Tim-Philipp Müller from comment #1)
> Not sure a leak in a unit test is 'critical' :)

If you are running CI with valgrind, it will go the same color red as with any other failures, making it a blocker IMO :)