After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762211 - rtpjitterbuffer: Don't drop packets after big gap
rtpjitterbuffer: Don't drop packets after big gap
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal critical
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-17 18:49 UTC by Håvard Graff (hgr)
Modified: 2016-02-18 07:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test and fix (2.66 KB, patch)
2016-02-17 18:49 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2016-02-17 18:49:00 UTC 
Created attachment 321532 [details] [review]
test and fix

Make sure that the packets queued when detecting a big gap are pushed
after reset (5 consective seqnums) and not dropped.
Comment 1 Tim-Philipp Müller 2016-02-18 00:38:13 UTC 
This looks like something that was fixed independently recently.

Is the patch to the jitterbuffer actually neeed? The test seems to pass fine without it.
Comment 2 Sebastian Dröge (slomo) 2016-02-18 07:38:30 UTC 
This should be fixed by

commit e4b2360e6e5bff335a6b688a03a2385bcb8ea9c0
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Dec 9 12:24:09 2015 +0200

    rtpjitterbuffer: Fix packet dropping after a big discont
    
    We would queue 5 consective packets before considering a reset and a proper
    discont here. Instead of expecting the next output packet to have the current
    seqnum (i.e. the fifth), expect it to have the first seqnum. Otherwise we're
    going to drop all queued up packets.
Comment 3 Sebastian Dröge (slomo) 2016-02-18 07:41:30 UTC 
Comment on attachment 321532 [details] [review]
test and fix

Confirmed, test fails without my change and works with. So let's get the test integrated:

commit 3eeca9c7d20bac6f4da1e1100982836539a2daf7
Author: Stian Selnes <stian@pexip.com>
Date:   Tue Dec 8 18:49:40 2015 +0100

    rtpjitterbuffer: Add test for big seqnum gap handling
    
    Make sure that the packets queued when detecting a big gap are pushed
    after reset (5 consective seqnums) and not dropped.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762211