After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762203 - Display notifications about playing song when pausing
Display notifications about playing song when pausing
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
3.3
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-17 17:39 UTC by Sebastien Bacher
Modified: 2016-03-17 02:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't notify about pauses with no-action servers (1.11 KB, patch)
2016-02-22 14:34 UTC, Sebastien Bacher 		none Details | Review
an easier way to do that (655 bytes, patch)
2016-03-16 00:32 UTC, Jonathan Matthew 		none Details | Review

Description Sebastien Bacher 2016-02-17 17:39:16 UTC 
Using 3.3 on Ubuntu/Unity.

When pausing a song notify-osd displays a notification about the song. 

The notification might make sense when having actions since those let you play/pause but it doesn't really in that case since it only displays the artwork/title like if you started playing a new song.
Comment 1 Sebastien Bacher 2016-02-22 14:34:46 UTC 
Created attachment 321849 [details] [review]
Don't notify about pauses with no-action servers
Comment 2 Jonathan Matthew 2016-03-16 00:32:43 UTC 
Created attachment 324066 [details] [review]
an easier way to do that

I'd prefer to fix it this way.  Does this still work properly for you?
Comment 3 Sebastien Bacher 2016-03-16 08:45:42 UTC 
that seems to work as well, thanks!
Comment 4 Jonathan Matthew 2016-03-17 02:38:58 UTC 
I took another look at this and realised that we can narrow this down a bit further.  If plugin->notify_supports_icon_buttons is false, then updating the notification won't make any difference to it.  That field is only ever set to true with plugin->notify_supports_actions is true, so in Unity, this should work the same as the previous patch.

I've pushed the updated patch as commit aea7e34.