GNOME Bugzilla – Bug 762149
dashdemux: tests: added tests for live streams
Last modified: 2018-11-03 13:46:27 UTC
Add various tests for testing dash demux behavior while playing live streams
Created attachment 321398 [details] [review] 1/6 added livestream test
Created attachment 321400 [details] [review] 2/6 added livestream test with presentation delay
Created attachment 321401 [details] [review] 3/6 added test for timeshiftBufferDepth
Created attachment 321402 [details] [review] 4/6 added query test for live stream
Created attachment 321403 [details] [review] 5/6 added test for running 2 seek requests in parallel
Created attachment 321404 [details] [review] 6/6 added seek test for live streams
These tests require the following tickets to be merged first: https://bugzilla.gnome.org/show_bug.cgi?id=762142 https://bugzilla.gnome.org/show_bug.cgi?id=762144 https://bugzilla.gnome.org/show_bug.cgi?id=762147 https://bugzilla.gnome.org/show_bug.cgi?id=762148
Review of attachment 321403 [details] [review]: This patch makes the test fail to build: elements/dash_demux.c:1018:26: error: ‘GstAdaptiveDemuxTestCase {aka struct _GstAdaptiveDemuxTestCase}’ has no member named ‘test_task_state_lock2’ g_mutex_lock (&testData->test_task_state_lock2);
(In reply to Thiago Sousa Santos from comment #8) > Review of attachment 321403 [details] [review] [review]: > > This patch makes the test fail to build: > > elements/dash_demux.c:1018:26: error: ‘GstAdaptiveDemuxTestCase {aka struct > _GstAdaptiveDemuxTestCase}’ has no member named ‘test_task_state_lock2’ > g_mutex_lock (&testData->test_task_state_lock2); It looks like the dependency upon https://bugzilla.gnome.org/show_bug.cgi?id=758961 was missed. I have updated https://bugzilla.gnome.org/show_bug.cgi?id=758961 so that it cleanly applies.
Created attachment 326775 [details] [review] adaptivedemux: tests: added test for running 2 seek requests in parallel Updated patch to apply cleanly and for the test to pass. The two patches from https://bugzilla.gnome.org/show_bug.cgi?id=758961 are prerequisites.
Created attachment 326779 [details] [review] adaptivedemux: tests: added seek test for live streams Obsoletes "6/6 added seek test for live streams" Re-based to apply cleanly on master.
Created attachment 358767 [details] [review] 1/6 tests: dashdemux: add live stream test Re-based to master, on top of the fixes in https://bugzilla.gnome.org/show_bug.cgi?id=781632
Created attachment 358768 [details] [review] 2/6 tests: dashdemux: add livestream test with presentation delay Re-based to master, on top of the fixes in https://bugzilla.gnome.org/show_bug.cgi?id=781632 Obsoletes https://bugzilla.gnome.org/attachment.cgi?id=321400
Created attachment 358769 [details] [review] 3/6 tests: dashdemux: add test for timeshiftBufferDepth Re-based to master, on top of the fixes in https://bugzilla.gnome.org/show_bug.cgi?id=781632 Obsoletes https://bugzilla.gnome.org/attachment.cgi?id=321401
Created attachment 358770 [details] [review] 4/6 tests: dashdemux: add query tests for live streams Re-based to master, on top of the fixes in https://bugzilla.gnome.org/show_bug.cgi?id=781632 Obsoletes https://bugzilla.gnome.org/attachment.cgi?id=321402
Created attachment 358771 [details] [review] 6/6 tests: dashdemux: add seek test for live streams Re-based to master, on top of the fixes in https://bugzilla.gnome.org/show_bug.cgi?id=781632 Obsoletes https://bugzilla.gnome.org/attachment.cgi?id=326779 and https://bugzilla.gnome.org/attachment.cgi?id=321404
All of the tests have now been updated to GStreamer master, expect for "5/6 added test for running 2 seek requests in parallel" patch which was difficult to rebase.
Created attachment 362636 [details] [review] 1/6 tests: dashdemux: add live stream test rebased to master updated based upon API changes on ticket https://bugzilla.gnome.org/show_bug.cgi?id=781632
Created attachment 362637 [details] [review] 2/6 tests: dashdemux: add livestream test with presentation delay rebased to master updated based upon API changes on ticket https://bugzilla.gnome.org/show_bug.cgi?id=781632
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/348.