GNOME Bugzilla – Bug 762129
rhythmbox segfaults in soup_server_unpause_message() when client try to connect
Last modified: 2016-02-20 13:49:26 UTC
Using ubuntu xenial with rhythmbox 3.3, libsoup 2.52.2 and libdmapsharing 2.9.33 rhythmbox has music sharing enabled with a password, when a client try to connect/enter the password rhythmbox segfaults that warning is displayed before the error "Object class RBDAAPRecord doesn't implement property 'hash' from interface 'DAAPRecord'" stacktrace "#0 0xb533149f in soup_server_unpause_message (server=0x3ff00000, msg=0x8e40358) at soup-server.c:2812
+ Trace 235975
the warning is about RBDAAPRecord so maybe a rb issue?
Created attachment 321489 [details] [review] Don't let the new share_bitwise_t share member uninitialized Turned out it's an issue added with the recent 2.9.33 update and commit https://git.gnome.org/browse/libdmapsharing/commit/?id=f6a4a648c5b1faf835c634d28289b6adfc5673b7 The share_bitwise->share value is never set
Created attachment 321490 [details] [review] use g_new0 to avoid uninitialized values that makes debugging such issues easier, in that case share=null
there seems to be other issues with that commit, rhythmbox also displays warning when closed g_value_set_object: assertion 'G_IS_OBJECT (v_object)' failed from_dmap_share_get_property() case PROP_SERVER: g_value_set_object (value, share->priv->server);
I just pushed some changes. Would you please test Git master?
> I just pushed some changes. Would you please test Git master? no segfault and no gobject warnings with, thanks! it would still be good to have the g_new0 change in I guess? (also unsure how you apply the change but if you use the attached file it should keep the author info, instead of having to credit in the message)
This problem is fixed in 2.9.34.