After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762124 - input-selector: remove some dead code
input-selector: remove some dead code
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-16 08:36 UTC by Guillaume Marquebielle
Modified: 2018-11-03 12:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch removing dead code (1.49 KB, patch)
2016-02-16 08:36 UTC, Guillaume Marquebielle
none Details | Review

Description Guillaume Marquebielle 2016-02-16 08:36:27 UTC
Created attachment 321345 [details] [review]
Patch removing dead code

In gst_input_selector_event () method, previous cleaning has left some dead code.

Don't know if initial idea of GList "pushed_pads" has to be reworked or is no more useful.
Comment 1 Tim-Philipp Müller 2016-11-11 19:03:55 UTC
Or maybe we should add the g_list_prepend() after forwarding just like it's done in gst_pad_forward() ? Not sure why Sebastian left that out originally when he added this code.
Comment 2 Tim-Philipp Müller 2016-11-11 19:05:04 UTC
It's relevant when a RESYNC happens (e.g. someone adds a new pad while we're iterating).

We could also just take the lock, iterate the list and not use iterator at all ;)
Comment 3 GStreamer system administrator 2018-11-03 12:33:10 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/158.