GNOME Bugzilla – Bug 762124
input-selector: remove some dead code
Last modified: 2018-11-03 12:33:10 UTC
Created attachment 321345 [details] [review] Patch removing dead code In gst_input_selector_event () method, previous cleaning has left some dead code. Don't know if initial idea of GList "pushed_pads" has to be reworked or is no more useful.
Or maybe we should add the g_list_prepend() after forwarding just like it's done in gst_pad_forward() ? Not sure why Sebastian left that out originally when he added this code.
It's relevant when a RESYNC happens (e.g. someone adds a new pad while we're iterating). We could also just take the lock, iterate the list and not use iterator at all ;)
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/158.