After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762098 - fix to make gtksink demo not hang on exit
fix to make gtksink demo not hang on exit
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.6.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2016-02-15 17:39 UTC by Caolan McNamara
Modified: 2016-04-14 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

plausible fix for hang on exit (2.01 KB, patch)
2016-02-15 17:39 UTC, Caolan McNamara
none Details | Review

Description Caolan McNamara 2016-02-15 17:39:37 UTC
Created attachment 321278 [details] [review]
plausible fix for hang on exit

The gtksink demo hangs for me on exit. The attached patch makes it work for me.

Valgrind reports...

==15887== Invalid read of size 4
==15887==    at 0x7247355: g_mutex_lock (in /usr/lib64/
==15887==    by 0x1D1BC983: widget_destroy_cb (gstgtkbasesink.c:155)
==15887==    by 0x6F75577: g_closure_invoke (in /usr/lib64/
==15887==    by 0x6F88151: ??? (in /usr/lib64/
==15887==    by 0x6F9145B: g_signal_emit_valist (in /usr/lib64/
==15887==    by 0x6F9182E: g_signal_emit (in /usr/lib64/
==15887==    by 0x51EBE87: ??? (in /usr/lib64/
==15887==    by 0x6F7BE6B: g_object_run_dispose (in /usr/lib64/
==15887==    by 0x51F8498: ??? (in /usr/lib64/
==15887==    by 0x4FAF98F: ??? (in /usr/lib64/
==15887==    by 0x6F75577: g_closure_invoke (in /usr/lib64/
==15887==    by 0x6F8871D: ??? (in /usr/lib64/
==15887==  Address 0x1c54b6e8 is 584 bytes inside a block of size 1,496 free'd
==15887==    at 0x4C2EE6C: free (vg_replace_malloc.c:530)
==15887==    by 0x72083ED: g_free (in /usr/lib64/
==15887==    by 0x721FA6F: g_slice_free1 (in /usr/lib64/
==15887==    by 0x6F99F96: g_type_free_instance (in /usr/lib64/
==15887==    by 0x6C6E3D0: ??? (in /usr/lib64/
==15887==    by 0x6C73598: gst_bin_remove (in /usr/lib64/
==15887==    by 0x6C737FA: ??? (in /usr/lib64/
==15887==    by 0x6F7A368: g_object_unref (in /usr/lib64/
==15887==    by 0x4014A4: destroy_cb (demo.c:69)
==15887==    by 0x5080F14: ??? (in /usr/lib64/
==15887==    by 0x6F757A6: ??? (in /usr/lib64/
==15887==    by 0x6F90CA2: g_signal_emit_valist (in /usr/lib64/
==15887==  Block was alloc'd at
==15887==    at 0x4C2DCBF: malloc (vg_replace_malloc.c:299)
==15887==    by 0x72082D8: g_malloc (in /usr/lib64/
==15887==    by 0x721F352: g_slice_alloc (in /usr/lib64/
==15887==    by 0x721F98D: g_slice_alloc0 (in /usr/lib64/
==15887==    by 0x6F99C7C: g_type_create_instance (in /usr/lib64/
==15887==    by 0x6F7A9DA: ??? (in /usr/lib64/
==15887==    by 0x6F7C95D: g_object_new_valist (in /usr/lib64/
==15887==    by 0x6F7CC10: g_object_new (in /usr/lib64/
==15887==    by 0x6C975DD: gst_element_factory_create (in /usr/lib64/
==15887==    by 0x6C9788D: gst_element_factory_make (in /usr/lib64/
==15887==    by 0x401903: main (demo.c:152)
Comment 1 Matthew Waters (ystreet00) 2016-02-16 09:13:25 UTC
Thanks for the bug report!

commit 057aca2cda1e03a2208f21894c8e263b7f91d38d
Author: Matthew Waters <>
Date:   Tue Feb 16 19:59:13 2016 +1100

    gtk(gl)sink: remove the signal handlers on finalize
    It's possible that the sink element will be freed before the widget is
    destroyed.  When the widget was eventually destroyed, it was attempting to
    access member variables of the freed sink struct which resulted in undefined
    Fix by disconnecting our signal on finalize.

And 1.6 a7108e62d79639c5b6c60a5e0c1396273790d170
Comment 2 Joe Gorse 2016-02-18 14:27:50 UTC
Tested this patch and it works as a fix for a crash I was seeing on an OS X client using the gtk (gl) sink.